#12083 closed defect (bug) (fixed)
Merge is_installed() into wp_not_installed() and is_blog_installed()
Reported by: | nacin | Owned by: | |
---|---|---|---|
Milestone: | 3.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Multisite | Keywords: | |
Focuses: | Cc: |
Description (last modified by )
wp_not_installed() checks is_blog_installed(), and if we're not installed (or installing), we die on error.
The MU/MS function is_installed() runs when not installing and when !$current_site && !current_blog.
We should be able to merge the largely overlapping functionality quite a bit and remove is_installed() entirely.
Also, we might want to consider introducing multisite tables to the list of tables to check for in is_blog_installed(), and/or allow repair.php to help when multisite.
We also don't need to check tables in $wpdb->old_tables, so if nothing else comes out of this ticket then that should go in. repair.php has a simple if ( in_array( $table, $wpdb->old_tables ) ) continue;
, and the functionality should be consistent.
We should also check for $wpdb->site instead of or in addition to $wpdb->options if multisite, the way is_installed() does.
Attachments (1)
Change History (9)
#5
@
15 years ago
After going over all of this again, I'm not sure how much more we ought to do here. Recommend closing as fixed.
(In [13224]) First pass at Multisite support in DB repair. When MS, include main blog tables; when not MS, include non-MS global tables (users, usermeta). See #12083