Make WordPress Core

Opened 17 years ago

Closed 17 years ago

#12094 closed defect (bug) (fixed)

Locked out of Network creation if process aborted half way

Reported by: dd32 Owned by: nacin
Priority: normal Milestone: 3.0
Component: Multisite Version: 3.0
Severity: normal Keywords:
Cc: Focuses:

Description

At present, The Network creation script expects that the process will be followed to the dot for the entire process.

If for example, The user navigates away on the .htaccess/wp-config.php page (without making the suggested changed), If they attempt to visit the page again they'll be given a "That network already exists!" error, even though WordPress will not be running in MultiSite mode yet.

Setting as blocker as i cannot see this being a good work flow for users.

The expected outcome would be either:

  1. WordPress erases the setup details given
  2. WordPress offers to start over
  3. (my preference) WordPress offers the .htaccess / wp-config.php details again (ie. Leaving off from where the user was last up to)

Attachments (1)

network-step1.diff​ (23.4 KB ) - added by nacin 17 years ago.

Download all attachments as: .zip

Change History (18)

#1 @dd32
17 years ago

  • Component General → Multisite

#2 @janeforshort
17 years ago

+1 on option C. Same thing happened to me. Very much expected to be able to get the text blocks again.

#3 follow-up: @wpmuguru
17 years ago

  • Owner set to wpmuguru
  • Status new → assigned

#4 in reply to: ↑ 3 @webmatter
17 years ago

Replying to wpmuguru:
Had the same error. Is there a quick fix available to have option C?

#5 @dd32
17 years ago

Had the same error. Is there a quick fix available to have option C?

I cleared (I think) the sites and blogs tables.. Alternativly, Just use your database backup :)

#6 @nacin
17 years ago

  • Owner changed from wpmuguru to nacin

Related: #11816. Going to incorporate this when handling wpfs.

#7 @wpmuguru
17 years ago

Mistakenly attributed [13000] to another ticket instead of this one.

#8 @wpmuguru
17 years ago

  • Priority normal → high

The work wpfs seems to have gotten lost in the track gardening sprint. This is one of the items holding releasing a test/alpha version for wider community testing.

Would the owner of the ticket please update the ticket with a timeframe for completion of working test version of the wpfs patch?

#9 @nacin
17 years ago

dd32 and I are going to finish this off in the next few days. By the weekend, I imagine everything can be in place.

I've attached a patch that begins to overhaul network.php, mainly the first step. It doesn't take into account wpfs (which would be step 2) or #12457 (which would be easy to add). Feedback encouraged.

My current thought is that we can actually get away with injecting MS constant defines into the current wp-config.php file. We'll still back it up, of course, but this prevents us from A) forcing people with various constants to do it manually, or B) needing to check for all sorts of constants that we'll want to copy over.

Instead, we'll just be able to check for any problematic constants (if any exist) that we can throw a flag for, and otherwise, define MULTISITE, VHOST, DOMAIN_CURRENT_SITE, PATH_CURRENT_SITE, SITE_ID_CURRENT_SITE, BLOGID_CURRENT_SITE, and $base.

@nacin
17 years ago

#10 @nacin
17 years ago

(In [13571]) First pass on network.php improvements. see #12094

#11 @nacin
17 years ago

(In [13572]) Second pass, replacing accidental ms-config-sample.php change with wp-config.ms. see #12094

#12 @nacin
17 years ago

(In [13572]) Second pass, replacing accidental ms-config-sample.php change with wp-config.ms. see #12094

#13 @nacin
17 years ago

(In [13577]) Support for extra POST fields in WP_Filesystem. props dd32. see #12094

#14 @wpmuguru
17 years ago

We should close either this ticket or #11816. The part about being locked out has been fixed. I think both tickets are sitting open to hang the wpfs patches.

#15 @nacin
17 years ago

  • Milestone 3.0
  • Priority high → normal
  • Resolution → duplicate
  • Severity blocker → normal
  • Status assigned → closed

makes sense to me. Let's continue in #11816.

#16 @dd32
17 years ago

  • Resolution duplicate
  • Status closed → reopened

#17 @dd32
17 years ago

  • Milestone → 3.0
  • Resolution → fixed
  • Status reopened → closed

Due to there being commits in this ticket, i'm closing this as fixed instead.

Note: See TracTickets for help on using tickets.