WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12102 closed defect (bug) (invalid)

WordpressMU install barfs errors about DB_NAME, DB_USER, DB_PASSWORD, DB_HOST, VHOST

Reported by: dxjones Owned by: donncha
Milestone: Priority: normal
Severity: normal Version: 2.9.1
Component: Upgrade/Install Keywords: install, constant, db_name, error, notice
Focuses: Cc:

Description

WordpressMU installer barfs out error messages that these constants are already defined: DB_NAME, DB_USER, DB_PASSWORD, DB_HOST, VHOST.

I think this is because both the index.php / index-install.php and wp-config.php include statements that "define" these constants.

Although these warnings may be harmless, they are very confusing (and unnecessarily sloppy) to anyone installing Wordpress for the first time.

-- David Jones

Notice: Constant DB_NAME already defined in /.../html/wp-config.php on line 23

Notice: Constant DB_USER already defined in /.../html/wp-config.php on line 26

Notice: Constant DB_PASSWORD already defined in /.../html/wp-config.php on line 29

Notice: Constant DB_HOST already defined in /.../html/wp-config.php on line 32

Notice: Constant VHOST already defined in /.../html/wp-config.php on line 39

Change History (3)

comment:1 nacin4 years ago

  • Owner changed from dd32 to donncha
  • Status changed from new to assigned

In plain WP, we link them to wp-admin/install.php, and avoid including WordPress in the same script after becoming db-aware.

Don't think this is an issue post-merge though. The installation and upgrade procedures have been re-worked.

Although these warnings may be harmless, they are very confusing (and unnecessarily sloppy) to anyone installing WordPress for the first time.

MU isn't designed for the faint of heart. There have been a ton of improvements to the codebase with the merge, mainly because it wasn't subject to the same code review that is getting now from many, many core contributors.

I've made points in other tickets for 2.9.1.2, but I don't think it's worth much of a fix here as we'll be reengineering index-install.php for not much benefit.

Assigning to donncha as this is a pre-merge ticket only.

comment:2 wpmuguru4 years ago

  • Resolution set to invalid
  • Status changed from assigned to closed

Sounds like the installation instructions were not followed.

In WordPress MU, wp-config.php is created by the installation process. The database defines are defined by index-install.php before wp-config.php is created.

comment:3 nacin4 years ago

  • Milestone Unassigned deleted
Note: See TracTickets for help on using tickets.