WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#12119 closed defect (bug) (fixed)

Wordpress MU - wpmu-blogs.php protocol is not respected everywhere

Reported by: stezz Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Multisite Keywords: has-patch
Focuses: Cc:

Description

recently there was a commit to take care of ${protocol}.

The change wasn't done everywhere in the file.

This patch should take care of that (please review).

Attachments (3)

wpmu-blogs.diff (2.9 KB) - added by stezz 11 years ago.
wpmu-blogs patch
12119.diff (2.8 KB) - added by ryan 11 years ago.
12119.2.diff (11.4 KB) - added by ryan 11 years ago.

Download all attachments as: .zip

Change History (10)

@stezz
11 years ago

wpmu-blogs patch

#1 @scribu
11 years ago

  • Component changed from Administration to Multisite
  • Keywords has-patch added
  • Milestone changed from Unassigned to 3.0

#2 @ryan
11 years ago

Just because I'm visiting the admin via https doesn't mean I want to view the blog in https. Ideally we should leverage home_url(), site_url(), admin_url(), etc. Perhaps an optional blog ID can be added to those.

@ryan
11 years ago

#3 follow-up: @ryan
11 years ago

Patch introduces get_home_url() which accepts a blog ID. home_url() remains for getting the home url for the current blog. The same should be done for the other function if we go this direction.

@ryan
11 years ago

#4 in reply to: ↑ 3 @wpmuguru
11 years ago

Replying to ryan:

Patch introduces get_home_url() which accepts a blog ID. home_url() remains for getting the home url for the current blog. The same should be done for the other function if we go this direction.

Patch looks good to me.

#5 @ryan
10 years ago

(In [12978]) Introduce get_home_url(), get_site_url(), and get_admin_url() for fetching urls by blog id. see #12119

#6 @wpmuguru
10 years ago

I'm assuming this one is done unless someone indicates otherwise.

#7 @wpmuguru
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

If there is an issue, this one can be reopened.

Note: See TracTickets for help on using tickets.