Wordpress MU - wpmu-blogs.php protocol is not respected everywhere

[stezz]

recently there was a commit to take care of ${protocol}.

The change wasn't done everywhere in the file.

This patch should take care of that (please review).

[stezz]

wpmu-blogs patch

[ryan]

Just because I'm visiting the admin via https doesn't mean I want to view the blog in https. Ideally we should leverage home_url(), site_url(), admin_url(), etc. Perhaps an optional blog ID can be added to those.

[ryan]

Patch introduces get_home_url() which accepts a blog ID. home_url() remains for getting the home url for the current blog. The same should be done for the other function if we go this direction.

[wpmuguru]

Replying to ryan:

Patch introduces get_home_url() which accepts a blog ID. home_url() remains for getting the home url for the current blog. The same should be done for the other function if we go this direction.

Patch looks good to me.

[ryan]

(In [12978]) Introduce get_home_url(), get_site_url(), and get_admin_url() for fetching urls by blog id. see #12119

[wpmuguru]

I'm assuming this one is done unless someone indicates otherwise.

[wpmuguru]

If there is an issue, this one can be reopened.