WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#12165 closed enhancement (fixed)

Edit media form has get variables in action

Reported by: reaperhulk Owned by:
Milestone: 3.0 Priority: lowest
Severity: trivial Version: 2.9.1
Component: Media Keywords: has-patch
Focuses: Cc:

Description

The wp-admin/media.php edit media form does not remove the edit and attachment_id query args when inserting the action URI. This does not cause any issues in practice because the wp_reset_vars function preferentially chooses $_POST over $_GET, but it does result in confusion for people trying to follow the program logic.

Attachments (1)

12165.patch (691 bytes) - added by reaperhulk 5 years ago.

Download all attachments as: .zip

Change History (7)

@reaperhulk5 years ago

comment:1 @reaperhulk5 years ago

  • Keywords has-patch added

comment:2 @scribu5 years ago

  • Milestone changed from Unassigned to 3.0

comment:3 follow-up: @nacin5 years ago

We might as well just post to itself (i.e. empty action attribute), no?

comment:4 in reply to: ↑ 3 @scribu5 years ago

Replying to nacin:

We might as well just post to itself (i.e. empty action attribute), no?

+1 (less is better :)

comment:5 @reaperhulk5 years ago

Agreed, easy fix and no need for the remove_query_arg call then.

comment:6 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.