Show status when changing admin email

[jane]

We should make it so that if someone changes the site admin address (under Settings > General), instead of it reverting to old address until the email confirmation link is clicked, we display what they tried to change it to and note that it is pending. Otherwise, it just looks like it didn't work, especially if the email doesn't show up right away.

If someone wants to whip this out to get into 3.0, awesome, otherwise will try to get it into 3.1.

[jorbin]

patch vs 13330 to change the description after the field for when there is a pending change

[jorbin]

When there is a pending change, I changed the description after the field to read:

There is a pending change of the admin e-mail to: $new_admin_email

[jorbin]

Screenshot of pending change

[jorbin]

Version with class='updated' to draw more attention

[jorbin]

Patch that adds a yellow box around the message to draw attention to it.

[jorbin]

Added a second patch that adds the updated class to put the notice in yellow

[jorbin]

actual patch to apply

[nacin]

We generally use div.updated p, that way it doesn't look scrunched up. That said, if you tried to use that, then some JavaScript would have moved it to the top.

Personally, I prefer this as a notice across the top, though I can certainly settle for an inline notification. We'll need Jane to weigh in, as she proposed something a bit different originally.

[jorbin]

Yesterday in the #wordpress-dev Jane signed off on the implementation done in r13408.diff . See Screenshot-2.png for what is added on a pending email change

[jorbin]

Puts notice in <div class='updated inline'>

[nacin]

(In [13446]) Show a notice when changing a multisite's site admin email. props jorbin. Introduce an .inline class that can be used with div.updated and div.error, to prevent the message from being moved to the top of the page. see #12192

[nacin]

Okay, this one is in. It looks good. Just a note, this is only multisite -- we don't require e-mail confirmation in a single-site setup. The ticket wasn't clear and the diff actually patched the non-multisite code, so I wanted to make note of this.

Jane, if you like, feel free to => fixed.

[nacin]

This looks good, so closing as fixed.

[ryan]

Whenever you Save Changes in options-general.php, new_admin_email is set in the options table. With this change you will then see the pending change notice even though you haven't actually changed the email address. We should either check to see if new_admin_email is the same as admin_email or not save new_admin_email at all.

[ocean90]

I would appreciate it if we could do the same for the network e-mail address on ms-options.php.

[nacin]

(In [13705]) Only show multisite admin email notice if the email was changed. Add a "Cancel" link so the nag doesn't stay forever if the admin ends up not changing the email. see #12192

[ryan]

(In [14242]) Hook update_option_new_admin_email to add_option_new_admin_email so that the confirmation email gets set even when new_admin_email doesn't already exist. see #12192