WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#12192 closed enhancement (fixed)

Show status when changing admin email

Reported by: jane Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: UI Keywords: commit
Focuses: Cc:
PR Number:

Description

We should make it so that if someone changes the site admin address (under Settings > General), instead of it reverting to old address until the email confirmation link is clicked, we display what they tried to change it to and note that it is pending. Otherwise, it just looks like it didn't work, especially if the email doesn't show up right away.

If someone wants to whip this out to get into 3.0, awesome, otherwise will try to get it into 3.1.

Attachments (8)

r13330.txt (957 bytes) - added by jorbin 10 years ago.
patch vs 13330 to change the description after the field for when there is a pending change
Screenshot.png (30.7 KB) - added by jorbin 10 years ago.
Screenshot of pending change
Screenshot-1.png (39.8 KB) - added by jorbin 10 years ago.
Version with class='updated' to draw more attention
options-general.php (12.2 KB) - added by jorbin 10 years ago.
Patch that adds a yellow box around the message to draw attention to it.
Screenshot-2.png (44.5 KB) - added by jorbin 10 years ago.
r13408.txt (993 bytes) - added by jorbin 10 years ago.
actual patch to apply
r13408.diff (993 bytes) - added by jorbin 10 years ago.
r13443.diff (1023 bytes) - added by jorbin 10 years ago.
Puts notice in <div class='updated inline'>

Download all attachments as: .zip

Change History (20)

@jorbin
10 years ago

patch vs 13330 to change the description after the field for when there is a pending change

#1 @jorbin
10 years ago

  • Cc aaron@… added
  • Keywords has-patch added
  • Version changed from 2.9.1 to 3.0

When there is a pending change, I changed the description after the field to read:

There is a pending change of the admin e-mail to: $new_admin_email

@jorbin
10 years ago

Screenshot of pending change

@jorbin
10 years ago

Version with class='updated' to draw more attention

@jorbin
10 years ago

Patch that adds a yellow box around the message to draw attention to it.

#2 @jorbin
10 years ago

Added a second patch that adds the updated class to put the notice in yellow

@jorbin
10 years ago

@jorbin
10 years ago

actual patch to apply

@jorbin
10 years ago

#3 @nacin
10 years ago

  • Component changed from Administration to UI
  • Reporter changed from janeforshort to jane

We generally use div.updated p, that way it doesn't look scrunched up. That said, if you tried to use that, then some JavaScript would have moved it to the top.

Personally, I prefer this as a notice across the top, though I can certainly settle for an inline notification. We'll need Jane to weigh in, as she proposed something a bit different originally.

#4 @jorbin
10 years ago

  • Keywords commit added; has-patch removed

Yesterday in the #wordpress-dev Jane signed off on the implementation done in r13408.diff . See Screenshot-2.png for what is added on a pending email change

@jorbin
10 years ago

Puts notice in <div class='updated inline'>

#5 @nacin
10 years ago

(In [13446]) Show a notice when changing a multisite's site admin email. props jorbin. Introduce an .inline class that can be used with div.updated and div.error, to prevent the message from being moved to the top of the page. see #12192

#6 @nacin
10 years ago

Okay, this one is in. It looks good. Just a note, this is only multisite -- we don't require e-mail confirmation in a single-site setup. The ticket wasn't clear and the diff actually patched the non-multisite code, so I wanted to make note of this.

Jane, if you like, feel free to => fixed.

#7 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This looks good, so closing as fixed.

#8 @ryan
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Whenever you Save Changes in options-general.php, new_admin_email is set in the options table. With this change you will then see the pending change notice even though you haven't actually changed the email address. We should either check to see if new_admin_email is the same as admin_email or not save new_admin_email at all.

#9 @ocean90
10 years ago

I would appreciate it if we could do the same for the network e-mail address on ms-options.php.

#10 @nacin
10 years ago

(In [13705]) Only show multisite admin email notice if the email was changed. Add a "Cancel" link so the nag doesn't stay forever if the admin ends up not changing the email. see #12192

#11 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

#12 @ryan
10 years ago

(In [14242]) Hook update_option_new_admin_email to add_option_new_admin_email so that the confirmation email gets set even when new_admin_email doesn't already exist. see #12192

Note: See TracTickets for help on using tickets.