WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#12193 closed defect (bug) (fixed)

Subtle code errors

Reported by: ScottMac Owned by: ryan
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Cache API Keywords:
Focuses: Cc:

Description

While doing some tests of a new tool we came across some code errors, one is a comparison that should be an assignment.

The others are calling methods with more parameters than they have in the caching layer.

Attachments (1)

wordpress-patch.txt​ (1.2 KB) - added by ScottMac 5 years ago.

Download all attachments as: .zip

Change History (4)

@ScottMac — 5 years ago

comment:1 @nacin — 5 years ago

  • Component changed from General to Cache
  • Milestone changed from Unassigned to 3.0
  • Owner set to ryan

See [6539], looks like that's a deprecated argument for WP_Object_Cache::get() from when persistent cache was pulled.

If you upload patches with a ".diff" or ".patch" extension, Trac will show them much better.

comment:2 @nacin — 5 years ago

Also, not sure if it's worth fixing, but s/existant/existent/ would correct a misspelling in a class property.

comment:3 @ryan — 5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13054]) Fix typos. Fix assignment. Remove passing of non-existent arg. Props ScottMac. fixes #12193

Note: See TracTickets for help on using tickets.