Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#12225 closed defect (bug) (fixed)

"This file is too big." Message does not go away after selecting a second image which does fit the maximum size.

Reported by: dragonflyeye Owned by: yoavf
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.9.1
Component: Upload Keywords: has-patch needs-testing
Focuses: Cc:


WordPress MU 2.9.1.
Steps to reproduce the problem:

  1. Start a new post
  2. Click "Add Image" button
  3. Select an image which is too big. Now you've got the error message on your screen, "This file is too big. The maximum upload size for your server is X."
  4. Select a new image which does fit the maximum size for your setup.
  5. The new image uploads fine, but the message still appears in the same location, making it look that this file is also too large.

Attachments (2)

3.0.uploaderror.diff (324 bytes) - added by yoavf 6 years ago.
12225.2.diff (477 bytes) - added by wpmuguru 6 years ago.

Download all attachments as: .zip

Change History (10)

#1 @nacin
6 years ago

  • Component changed from General to Upload
  • Milestone changed from Unassigned to 3.0

#2 @yoavf
6 years ago

  • Keywords has-patch css added
  • Owner set to yoavf
  • Status changed from new to assigned
  • Version changed from 2.9.1 to 3.0

6 years ago

#3 @wpmuguru
6 years ago

The position:relative didn't fix that for me in FF 3.0. Try the patch I attached and see if it's good across browsers.

#4 @dd32
6 years ago

  • Keywords needs-testing added; css removed
  • Version changed from 3.0 to 2.9.1

Resetting version, Please leave that at the originally reported (or earliest known edition the bug exists in) for bug tracking purposes.

#5 @dd32
6 years ago

Also note, This isnt a MU/Multisite specific bug, Any error will trip this, such as uploading a file which falls outside of the "security guidelines", ie. a .php file.

I'm not sure CSS is the right way to go here, Ideally, upon error, the media row should stay (as it is in the crunching stage) and the error be added to the div.

Either that, or all upload file errors be cleared upon uploading a 2nd file, as currently, they just build up at the top of the table.

#6 @dd32
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14816]) Better display handling of error messages during swfupload uploading. Fixes #12225

#7 @dd32
5 years ago

(In [15215]) Commit .dev version of wp-admin.css for r14816. See #12225

#8 @dd32
5 years ago

(In [15216]) re-minify wp-admin.dev.css after r15215. See #12225

Note: See TracTickets for help on using tickets.