WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12268 closed defect (bug) (fixed)

image_resize() should fail consistently

Reported by: filosofo Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Media Keywords: has-patch commit
Focuses: Cc:

Description

Currently, in all but one failure condition it returns a WP_Error object. It should return a WP_Error object when it fails to get the calculated dimensions, too.

And besides, the documentation is wrong.

Attachments (1)

consistent_image_resize_failure.12268.diff (1.1 KB) - added by filosofo 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 nacin4 years ago

  • Keywords commit added; image_resize removed

Looks good to me.

comment:2 nacin4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14105]) Consistently return WP_Error on failure in image_resize. props filosofo, fixes #12268

Note: See TracTickets for help on using tickets.