Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#12276 closed defect (bug) (duplicate)

do_pings/do_all_pings emit E_WARNINGs on malformed URLs

Reported by: rowanbeentje Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Pings/Trackbacks Keywords:
Focuses: Cc:


When running WP_CRON, do_pings/do_all_pings causes E_WARNINGs and may abort on malformed URLs.

The backtrace looks like:
wp_cron.php: do_action_ref_array('do_pings')
wp_includes/plugin.php: do_all_pings()
wp_includes/comment.php: do_enclose()
wp_includes/functions.php: parse_url('http://')

Obviously this is as a result of bad HTML, but then bad HTML is always bound to happen!

Both calls of parse_url within do_enclose should probably be silenced and the return values checked, returning if the URL can't be parsed?

Change History (4)

comment:1 @rowanbeentje6 years ago

Oops, sorry, I could have formatted the backtrace properly! Hopefully you get the idea though...

comment:2 @nacin6 years ago

  • Keywords needs-patch added
  • Milestone changed from Unassigned to Future Release

comment:3 @solarissmoke5 years ago

  • Keywords needs-patch removed
  • Resolution set to duplicate
  • Status changed from new to closed

comment:4 @nacin5 years ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.