WordPress.org
Get WordPress

Make WordPress Core

Opened 17 years ago

Closed 16 years ago

Last modified 14 years ago

#12277 closed defect (bug) (duplicate)

Test-Suite: Cross-Plattform portability: No Color Codes in Windows Shell

Reported by: hakre Owned by: westi
Priority: normal Milestone:
Component: Unit Tests Version:
Severity: normal Keywords: has-patch tested
Cc: Focuses:

Description

The Windows Shell does not provide any colors. Well to be more precise it does support colors but not the way PHPUnit_TextUI_ResultPrinter handles them.

A fix is to not output color-codes on windows.

Attachments (2)

12277.patch​ (581 bytes ) - added by hakre 17 years ago.
Worked like a charm.
12277.phpunit.xml.patch​ (387 bytes ) - added by mbijon 14 years ago.
Disables color codes for Windows, post-June 2012 testrunner

Download all attachments as: .zip

Change History (12)

@hakre
17 years ago

Worked like a charm.

#1 @hakre
17 years ago

  • Keywords tested added

Tested: I had run the suite with this patch applied on windows and it worked as intended.

Testsuite Windows Compability Related: #11867

#2 @nacin
17 years ago

  • Milestone 3.0

Moving out of 3.0.

#3 @hakre
16 years ago

Didn't you wanted to have unit-tests with WP 3.0? This patch would help to get things in order.

#4 @nacin
16 years ago

They're not milestone-dependent... I'm just clearing the 3.0 report. We have a report now specifically for unit tests.

#6 @hakre
16 years ago

  • Keywords needs-unit-tests added

#7 @hakre
16 years ago

  • Keywords needs-unit-tests removed

#8 @hakre
16 years ago

  • Summary Increase Cross-Plattform portability of the Testsuite: No Color Codes in Windows Shell → Test-Suite: Cross-Plattform portability: No Color Codes in Windows Shell

#9 @nacin
16 years ago

  • Resolution → duplicate
  • Status new → closed

​http://unit-tests.trac.wordpress.org/ticket/2

#10 @mbijon
14 years ago

  • Cc mike@… added

This patch is not valid for disabling color codes in Windows after closing #42, in June 2012.

After June 2012, the fix is now to set colors="false" in the test suite's phpunit.xml. It's simple, a patch isn't really needed, but is attached for reference.

@mbijon
14 years ago

Disables color codes for Windows, post-June 2012 testrunner

Note: See TracTickets for help on using tickets.