WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#12285 closed task (blessed) (fixed)

Migrate Link Categories management page to edit-tags.php

Reported by: dd32 Owned by:
Milestone: 3.1 Priority: high
Severity: normal Version: 3.0
Component: Administration Keywords: needs-patch
Focuses: Cc:

Description

In 3.0 with #11838, I've migrated the Categories page and any custom taxonomies to use the edit-tags.php file to prevent duplication of data.

Link categories has remained untouched during this process, and currently duplicates much of the taxonomy editing pages.

We should transition the Link Categories over too (And allow for taxonomies to register themselves for links as well).

One of the issues is that the taxonomy page is currently setup for post type handling, Which may require a bit of handling the post_type=link as a internal dummy post_type for the purpose of links. Or at least, Thats one way of approaching it.

Attachments (1)

12285.diff (911 bytes) - added by sorich87 4 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 dd324 years ago

See Also: http://core.trac.wordpress.org/ticket/12553#comment:3 which brings up this related issue.

comment:2 blepoxp4 years ago

It looks like scribu's massive patch addressed this when he added the default-list-tables. Is there any of the above work left to be done?

comment:3 dd324 years ago

It looks like scribu's massive patch addressed this when he added the default-list-tables.

Looks like it.

I'd like to double-check that the old actions have been carried across however (If someone can check that, Feel free to close this ticket)

comment:4 nacin4 years ago

  • Milestone changed from Awaiting Triage to 3.1
  • Priority changed from normal to high

sorich874 years ago

comment:5 sorich874 years ago

  • Cc sorich87@… added
  • Keywords has-patch added; early removed

This patch addresses two small remaining things.

I was not sure if 'edit-link-categories.php' and 'edit-link-category-form.php' should be removed or deprecated.

comment:6 dd324 years ago

I was not sure if 'edit-link-categories.php' and 'edit-link-category-form.php' should be removed or deprecated.

They'll probably just get removed, no real point in having them around I don't feel..

comment:7 nacin4 years ago

We didn't restore any files we removed in 3.0. These should go too.

comment:8 dd324 years ago

My only thought was related to back-compat for existing links, but I don't think that'll be a huge problem.

I'll remove the files once I get around to comparing the hook firing..

comment:9 nacin4 years ago

[15788] - My bad, but ultimately affects nothing. Just wanted to document that here.

comment:10 scribu4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15820]) Get rid of old link category management files. Fixes #12285

comment:11 automattor4 years ago

(In [15823]) The Hook that never was. Use correct / Revert back-compat hookname changes in [15820]. See #12285

comment:12 dd323 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Just noticed that none of the Ajax handlers were modified/removed.

for example: http://core.trac.wordpress.org/browser/trunk/wp-admin/admin-ajax.php?rev=15956#L363

comment:13 scribu3 years ago

(In [15963]) Remove dead 'delete-link-cat' ajax handler. See #12285

comment:14 scribu3 years ago

  • Keywords needs-patch added; has-patch removed

The only one left is 'add-link-category', which is called from link_categories_meta_box(), which should be made into a wrapper for the normal category metabox.

comment:15 nacin3 years ago

  • Type changed from enhancement to task (blessed)

Marking as a task as an extension of #14579.

comment:16 ryan3 years ago

All 3.1 work done?

comment:17 scribu3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Yeah, guess we can call it a day.

Note: See TracTickets for help on using tickets.