Migrate Link Categories management page to edit-tags.php

[dd32]

In 3.0 with #11838, I've migrated the Categories page and any custom taxonomies to use the edit-tags.php file to prevent duplication of data.

Link categories has remained untouched during this process, and currently duplicates much of the taxonomy editing pages.

We should transition the Link Categories over too (And allow for taxonomies to register themselves for links as well).

One of the issues is that the taxonomy page is currently setup for post type handling, Which may require a bit of handling the post_type=link as a internal dummy post_type for the purpose of links. Or at least, Thats one way of approaching it.

[dd32]

See Also: ​http://core.trac.wordpress.org/ticket/12553#comment:3 which brings up this related issue.

[blepoxp]

It looks like scribu's massive patch addressed this when he added the default-list-tables. Is there any of the above work left to be done?

[dd32]

It looks like scribu's massive patch addressed this when he added the default-list-tables.

Looks like it.

I'd like to double-check that the old actions have been carried across however (If someone can check that, Feel free to close this ticket)

[sorich87]

This patch addresses two small remaining things.

I was not sure if 'edit-link-categories.php' and 'edit-link-category-form.php' should be removed or deprecated.

[dd32]

I was not sure if 'edit-link-categories.php' and 'edit-link-category-form.php' should be removed or deprecated.

They'll probably just get removed, no real point in having them around I don't feel..

[nacin]

We didn't restore any files we removed in 3.0. These should go too.

[dd32]

My only thought was related to back-compat for existing links, but I don't think that'll be a huge problem.

I'll remove the files once I get around to comparing the hook firing..

[nacin]

[15788] - My bad, but ultimately affects nothing. Just wanted to document that here.

[scribu]

(In [15820]) Get rid of old link category management files. Fixes #12285

[automattor]

(In [15823]) The Hook that never was. Use correct / Revert back-compat hookname changes in [15820]. See #12285

[dd32]

Just noticed that none of the Ajax handlers were modified/removed.

for example: ​http://core.trac.wordpress.org/browser/trunk/wp-admin/admin-ajax.php?rev=15956#L363

[scribu]

(In [15963]) Remove dead 'delete-link-cat' ajax handler. See #12285

[scribu]

The only one left is 'add-link-category', which is called from link_categories_meta_box(), which should be made into a wrapper for the normal category metabox.

[nacin]

Marking as a task as an extension of #14579.

[ryan]

All 3.1 work done?

[scribu]

Yeah, guess we can call it a day.