WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12292 closed defect (bug) (fixed)

Create missing .dev stylesheets and fix RTL handling

Reported by: nacin Owned by: nacin
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords:
Focuses: Cc:

Description

We need to create any missing .dev stylesheets and also fix WP_Styles to handle dev versions of RTL sheets properly.

Attachments (2)

12292.diff (36.3 KB) - added by matveb 4 years ago.
Added the missing rtl.dev.css files. Not sure if this is the right way to do it.
12292.2.diff (2.7 KB) - added by nacin 4 years ago.
Full RTL+.dev support

Download all attachments as: .zip

Change History (8)

matveb4 years ago

Added the missing rtl.dev.css files. Not sure if this is the right way to do it.

comment:1 nacin4 years ago

(In [13238]) Minify remaining RTL css files, and ie.css. See #12292.

comment:2 nacin4 years ago

Sorry matveb, didn't see your attachment. (Attachments are silent posts in our notification system.)

I've minified the remaining RTL sheets, which included some pretty tiny sheets, but it will allow us to use -rtl.dev.css files effectively and without too much hacking.

I've attached a patch that takes care of script-loader.php and WP_Styles. Comments welcome. We can probably make a few more changes and get rid of some of the smaller minified RTL files.

nacin4 years ago

Full RTL+.dev support

comment:3 nacin4 years ago

(In [13239]) Suffix and version bump for ie.css, see #12292

comment:4 nacin4 years ago

I'd like to come up with a better way to do this (see 12292.2.diff as a start) that prevents us from minifying stylesheets we don't need to minify (take this one for example), leading to file bloat.

Patch welcome.

comment:5 automattor4 years ago

(In [13351]) Proper RTL + .dev.css support, first pass. See #12292

comment:6 nacin4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing as fixed for now. Ideally, we'd make some changes to the dependencies to prevent us from minifying RTL stylesheets we don't need to minify.

Note: See TracTickets for help on using tickets.