WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#12329 closed defect (bug) (worksforme)

Fix proposed for sidebar widget code to be HTML5 compliant

Reported by: gfitzp Owned by: azaozz
Milestone: Priority: normal
Severity: normal Version: 2.9.2
Component: Widgets Keywords: has-patch needs-testing 2nd-opinion HTML5
Focuses: Cc:

Description

Using the code from the Widgetizing Themes tutorial for my sidebar, I found that it wasn't producing HTML5 compliant code since it was missing the appropriate <ul> and </ul> tags. I've updated the wp-includes/widgets.php file to produce code that's worked for me to pass validation and have a diff for patching, but just want to make sure that I've dotted all my i's and crossed all my t's and that I'm not overlooking anything.

Attachments (1)

patch.txt (579 bytes) - added by gfitzp 5 years ago.
Diff of the wp-includes/widgets.php file for patching

Download all attachments as: .zip

Change History (3)

@gfitzp5 years ago

Diff of the wp-includes/widgets.php file for patching

comment:1 @greenshady5 years ago

The opening <ul> and closing </ul> should be in your template that's calling the sidebar. Each widget, by default, is a single list item (<li>).

comment:2 @nacin5 years ago

  • Milestone Unassigned deleted
  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.