Invalid feed type returns 500 HTTP response

[aaroncampbell]

It looks like passing a bad value to the get variable "feed" gives an HTTP response 500 (see ​http://ma.tt/?feed=1234). That doesn't sound like the right response. It seems like it should be a 40x response. I read the ​Status Code Definitions, but I'm not totally sure which one is most appropriate. The attached patch changes it to send a 404.

[beaulebens]

I would agree that it should be either a 404 or a 401 (Bad Request).

[nacin]

Replying to beaulebens:

I would agree that it should be either a 404 or a 401 (Bad Request).

I imagine you mean 400 -- 401 is for a failed HTTP auth.

404 seems fine to me if we want to be more generic than 400.

[aaroncampbell]

Sounds like 404 makes sense then. Can we get this applied?

[westi]

404 make sense to me.

What you asked for wasn't found.

[westi]

(In [13408]) Return a 404 error if the request feed type doesn't exist not a 500. Fixes #12341 props aaroncampbell.

[aaroncampbell]

Thanks. Do you think there's any chance of getting this into the 2.9 branch?

I'd like to be able to tell my client (the one where I discovered the issue) that they're safe to do any upgrades...rather than tell them they're safe to upgrade "once 3.0 is out"