WP should also catch E_CORE_ERROR | E_CORE_WARNING | E_COMPILE_ERROR

[Denis-de-Bernardy]

When writing PHP 5 code, and using the static operator, you can end up with a blank screen in WP. Inheriting a class with a static function and overriding it with a non-static function, for instance, triggers an E_COMPILE or E_CORE (not sure which one exactly), and this leads to a blank screen unless WP_DEBUG is switched on.

The attached patch (it's against 2.9.2, but I take it that it'll apply fine to trunk) adds E_CORE and E_COMPILE to the errors reported by WP.

It also fixes an E_NOTICE when COOKIEHASH is already defined.

[dd32]

broken patch. wp-settings.php & plugins.php do not apply.

[dd32]

(In [13499]) Display PHP Start-up Errors/Warnings. Props Denis-de-Bernardy. Fixes #12395.

[nacin]

Suggesting backport to 2.9 branch.

[Denis-de-Bernardy]

Replying to nacin:

Suggesting backport to 2.9 branch.

we have a new security hole?

[nacin]

It's not a security hole, but since there are fatal errors we're declining to report, we can cause annoying white screens of death.

This includes blank iframes when showing a fatal compile error generated by a plugin. This was seen on wp-hackers when a plugin used a function name that was already being used elsewhere. We made another change in [13167] that prevents the error scrape from overriding WP_DEBUG, which would otherwise have shown the compile error.

[eddieringle]

Backported to 2.9 in my patch. Haven't been following all the 3.0 changes, but I'm assuming that the error reporting levels that are set in wp-includes/load.php (which is in 3.0 but not 2.9) were moved from wp-settings.php.

[eddieringle]

2.9 backport of 12395.3.diff

[nacin]

(In [14250]) Display PHP start-up errors/warnings. fixes #12395 for 2.9. props eddieringle.

[nacin]

Milestone 2.9.3 deleted