Opened 11 years ago
Closed 11 years ago
#12398 closed defect (bug) (fixed)
Reinstate manage_pages_columns filter missing in wp_manage_posts_columns()
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.0 | Priority: | high |
Severity: | normal | Version: | 3.0 |
Component: | Editor | Keywords: | has-patch, commit |
Focuses: | Cc: |
Description
It looks like the abstraction work in wp-admin/includes/template.php, specifically in function wp_manage_posts_columns(), is missing the manage_pages_column filter. (There's a @todo at line 672).
This issue is related to #9674https://core.trac.wordpress.org/ticket/9674
Attachments (2)
Change History (9)
#2
@
11 years ago
Oops! Forgot about custom post types. Ok, I've added something for custom post types, using the format manage_{$post_type}_columns. Since custom post types can be named anything, this seems the logical way to do it.
#3
follow-up:
↓ 5
@
11 years ago
- Owner set to nacin
- Status changed from new to reviewing
manage_{$post_type}_columns might not work as it might clash with other existing filters, such as one in get_column_headers() and 'manage_media_columns'.
This is a good start though. Just a style note, we generally put the variable on the right in comparisons, that way you don't accidentally do an assignment (see your first patch).
#5
in reply to:
↑ 3
@
11 years ago
Replying to nacin:
manage_{$post_type}_columns might not work as it might clash with other existing filters, such as one in get_column_headers() and 'manage_media_columns'.
This is a good start though. Just a style note, we generally put the variable on the right in comparisons, that way you don't accidentally do an assignment (see your first patch).
Thanks for pointing that out. :-)
What about custom post types? Shouldn't they also have that filter present?