WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#12409 closed defect (bug) (fixed)

Users can't remove on ms-sites.php

Reported by: ocean90 Owned by: westi
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Warnings/Notices Keywords:
Focuses: multisite Cc:

Description

On domain.de/wp-admin/ms-sites.php?action=editblog&id=1 I get the notice

Array to string conversion in /wp-includes/ms-blogs.php on line 316

And so it doesn't show on meta box "Site User" the roles of the users.

Then check a user for remove and click the button, some new notices:

Notice: Undefined index: update_home_url in /var/www/web39/html/blog/wp-admin/ms-edit.php on line 206

Notice: Undefined index: role in /wp-admin/ms-edit.php on line 225

Notice: Undefined index: role in /wp-admin/ms-edit.php on line 247


On subdomain like sub.domain.de/wp-admin/ms-sites.php?action=editblog&id=1 the roles exists, but a notice by removing a user:

Notice: Undefined index: update_home_url in /var/www/web39/html/blog/wp-admin/ms-edit.php on line 206

Attachments (1)

ms-edit.php.patch (1.8 KB) - added by ocean90 11 years ago.

Download all attachments as: .zip

Change History (9)

#1 @wpmuguru
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13460]) warnings cleanup, dont show removed user in edit site, fixes #12409

#2 @nacin
11 years ago

  • Keywords multisite added

#3 follow-up: @ocean90
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I will add a patch for some notice that still exist.

#4 in reply to: ↑ 3 ; follow-up: @nacin
11 years ago

Replying to ocean90:

I will add a patch for some notice that still exist.

Either way, make sure this stays open, the logic in [13460] looks like it'll still throw a warning if !isset( $val->meta_value )...

#5 in reply to: ↑ 4 @ocean90
11 years ago

Replying to nacin:

Either way, make sure this stays open, the logic in [13460] looks like it'll still throw a warning if !isset( $val->meta_value )...

No there is no warning, but I think we can use empty() for that

if ( empty( $val->meta_value ) ) 
  continue; 

#6 @wpmuguru
11 years ago

(In [13505]) more ms warnings cleanup, props ocean90, see #12409

#7 @ocean90
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

#8 @nacin
11 years ago

(In [13664]) get_blog_count() returns a number, not an object. Also, i18n fixes -- add plural string, and translator context. see #12531 for get_blog_count() discussion. see #12409 for ms-sites cleanup.

Note: See TracTickets for help on using tickets.