WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12417 closed defect (bug) (fixed)

XSS in wp-admin/options.php

Reported by: Denis-de-Bernardy Owned by: ryan
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.9.2
Component: Security Keywords:
Focuses: Cc:

Description

There are quite a few lines in there, such as:

<th scope='row'><label for='$option->option_name'>$option->option_name</label></th>

Change History (4)

comment:1 @nacin — 5 years ago

  • Milestone changed from 2.9.3 to 3.0

I just patched this, then realized we esc_attr() at the top of the loop, so we're secure here.

I'm going to move the esc_attr() down further so it's more obvious.

comment:2 @nacin — 5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13471]) Make it more obvious we're escaping values in options.php. fixes #12417

comment:3 @Denis-de-Bernardy — 5 years ago

I think you broke the label tag, in r13471.

comment:4 @nacin — 5 years ago

Correct. Second changeset didn't get posted here. r13472

Note: See TracTickets for help on using tickets.