WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 5 years ago

#12425 closed enhancement

Fallback theme code is not translatable / default theme in theme repo is not translatable — at Version 12

Reported by: Denis-de-Bernardy Owned by: westi
Milestone: 3.0 Priority: high
Severity: major Version: 3.0
Component: General Keywords: needs-patch
Focuses: Cc:

Description (last modified by westi)

Should we switch them both to the I18N version of kubrick/default

Change History (13)

@Denis-de-Bernardy5 years ago

comment:1 @dd325 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13500]) Allow WP_FALLBACK_THEME to be overridden. Props Denis-de-Bernardy. Fixes #12425

comment:2 @Denis-de-Bernardy5 years ago

  • Keywords needs-patch 2nd-opinion added; has-patch commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

re-opening, because I'm foreseeing a possibly trickier issue.

consider a user with the simplest theme possible. two files, index.php and style.css, that currently relies on get_header(), get_sidebar() and get_footer(). that user is currently relying on the default theme. making him use twentyten all of the sudden makes no sense.

in other words, we should: during the upgrade, add an option with a value of default; and during installs, add an option with a value of twentyten. and then use the option to set the define.

alternatively, we could tell these handful of users (there can't be that many) to add the appropriate define in their wp-config.php file. in this case, the existing fix works wonders.

comment:3 @technosailor5 years ago

In an upgrade, unless the user explicityl removes the default (Kubrick) theme, it will still be there. In a 3.0 install, they would get twentyten. I don't see this being any more of an edge case and suggest we close as invalid.

comment:4 @westi5 years ago

  • Keywords 2nd-opinion removed
  • Owner set to westi
  • Status changed from reopened to accepted

Working on a solution to this as well as #13009

comment:5 @westi5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [14365]) First pass of compatibility code for old themes which relied on using templates from the default theme without expressly identifying it as the parent theme.
Fixes #12425 and #13009.
The fallback to these template files is now depreceated and will be removed in a future version.

comment:6 @scribu5 years ago

Related: #13230

comment:7 @zeo5 years ago

westi, does theme-compat need to be localized or leave it as is? If yes, what's the domain for it? none?

comment:8 @nacin5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I think we can use the i18n version, in the kubrick/default textdomain. If it's not loaded, then we get English, that's fine too. If it doesn't exist, the theme wouldn't work anyway.

That said, wondering if we can just fall back to kubrick, and forgo theme-compat. If it doesn't exist, the theme wouldn't work anyway.

comment:10 @westi5 years ago

I went for untranslated to hi-light it more as being a dead-end.

Also I copied the files from the WordPress Extend version of the default theme so if we are going to use the I18N one we should update that as well as otherwise when people apply the suggested fix to there theme they will lose the translation goodness.

comment:11 @zeo5 years ago

Is there anyone still using comments-popup.php?

How about just copy from i18n repos to extend theme repos. But the Default theme in Extend is out of reach. How to submit patches? Themes trac seems dead anyway.

comment:12 @westi5 years ago

  • Description modified (diff)
  • Priority changed from normal to high
  • Severity changed from normal to major
  • Summary changed from allow to override the fallback theme to Fallback theme code is not translatable / default theme in theme repo is not translatable

Retitling to reflect current issues.

Raising Priority.

Note: See TracTickets for help on using tickets.