Opened 15 years ago
Closed 15 years ago
#12429 closed defect (bug) (fixed)
onclick/onClick attribute should all be lowercase
Reported by: | TobiasBg | Owned by: | |
---|---|---|---|
Milestone: | 3.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
dd32 mentioned that various code editors replace "onclick" attributes with "onClick".
However, this breaks XHTML validation as all attributes need to be lowercase.
Recent commits ([13242], [13503]) commited such changes to core.
Attached patch replaces all found (grep) occurances of "onClick" in core with "onclick".
Attachments (3)
Change History (12)
#2
@
15 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
attached patch catches a few more
#3
@
15 years ago
Will handle, though your patch would revert [13503]. Would this otherwise apply clean? Looks like .dev.js sheets are missing.
#4
@
15 years ago
Oh, sht. Didn't check in JavaScript files... Thanks Denis!
Although colorpicker.dev.js will probably need more cleanup, as having all uppercase attributes around a lowercase "onclick" doesn't look to good somehow (and is probably also invalid XHTML):
<A HREF="#" onclick="cp.select(document.forms[0].color,'pick');return false;" NAME="pick" ID="pick">Pick</A>
#5
@
15 years ago
Sorry for those again.. I cant for the life of me work out why my code edits are insisting changing those even with that functionality disabled! (And tortoise seems to miss case changes in the preview)
Patch replaces "onClick" with "onclick" throughout core