WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12438 closed defect (bug) (invalid)

doubled line @wp-login.php

Reported by: F J Kaiser Owned by:
Milestone: Priority: lowest
Severity: trivial Version: 2.9.2
Component: General Keywords:
Focuses: Cc:

Description

at line 146 in wp-login.php you got the following line doubled and the upper commented as "depracated". i don´t know if it's just something someone forgot, or anything else:

do_action('retreive_password', $user_login); Misspelled and deprecated

do_action('retrieve_password', $user_login);

should get deleted if not already.

Change History (5)

comment:1 @nacin5 years ago

  • Milestone Unassigned deleted
  • Resolution set to invalid
  • Status changed from new to closed

It's marked as misspelled and deprecated. We had it in there as misspelled for a while, so we can't just remove it and break any plugins hooking into it. Note s/retreive/retrieve/.

comment:2 follow-up: @Denis-de-Bernardy5 years ago

Maybe we could remove it? It's been deprecated for quite some time, now...

comment:3 in reply to: ↑ 2 @nacin5 years ago

Replying to Denis-de-Bernardy:

Maybe we could remove it? It's been deprecated for quite some time, now...

We don't have a systematic way of marking deprecated hooks (something I've been considering), which means that unless the plugin noticed the added PHP comment in the source code, they'd never know.

comment:4 @Denis-de-Bernardy5 years ago

I was literally meaning removing it, and notifying the odd author or two that might still be using it. :-P

Note: See TracTickets for help on using tickets.