WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12440 closed defect (bug) (fixed)

Privacy On/Off links to options page, even if user has no rights

Reported by: pampfelimetten Owned by:
Milestone: 3.0 Priority: high
Severity: major Version: 3.0
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

"Privacy On" links to options page, even if user has no rights => if he clicks, he gets a "You do not have sufficient permissions to access this page."

Bad User experience, me thinks.

Attachments (1)

12440.diff (1.6 KB) - added by dd32 4 years ago.
one potential option

Download all attachments as: .zip

Change History (6)

comment:1 nacin4 years ago

Agreed, it should be restricted by cap. Easy enough.

dd324 years ago

one potential option

comment:2 dd324 years ago

  • Keywords has-patch 2nd-opinion added; needs-patch removed

The other option is to simply display '#' as the anchor, or use a span instead of <a> to prevent the link styles applying.

comment:3 follow-up: Denis-de-Bernardy4 years ago

  • Keywords 2nd-opinion removed

Imo, non-admins should not even see the message.

comment:4 in reply to: ↑ 3 nacin4 years ago

Replying to Denis-de-Bernardy:

Imo, non-admins should not even see the message.

I agree.

comment:5 nacin4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13559]) Only show "Privacy On" notice/link if the user can manage options. fixes #12440

Note: See TracTickets for help on using tickets.