Make WordPress Core

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#12441 closed enhancement (duplicate)

_fill_user() should use get_user_meta()

Reported by: scribu's profile scribu Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Optimization Keywords: has-patch commit
Focuses: Cc:


Currently, _fill_user() does a direct query, when it could be using get_user_meta(), which is cached.

Attachments (1)

_fill_user.diff (1.3 KB) - added by scribu 14 years ago.

Download all attachments as: .zip

Change History (5)

14 years ago

#1 @scribu
14 years ago

  • Keywords commit added

#2 @nacin
14 years ago

  • Milestone 3.0 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #11914 it seems

#3 @miqrogroove
14 years ago

Agreed. _fill_user() should never be called when the data are already cached, because the user object has already been filled. In any case, my patch already blows _fill_user() out of the water and hooks it up to goodies that are superior to get_user_meta(). :) Feedback would be appreciated on the other ticket.

#4 @voyagerfan5761
14 years ago

  • Cc WordPress@… added
Note: See TracTickets for help on using tickets.