pagination problem in unattached media page

[Denis-de-Bernardy]

when visiting media / unattached with multiple unattached media, you seem to end up with the wrong number of total pages, as highlighted in the attached screenshot.

[matdumsa]

I confirm the presence of the bug on my version of wordpress as well..

[matdumsa]

Actually I found the problem..

It lies in wp-admin/upload.php

It seems that the pagination system used by the media is the same as the one used for POSTS.. It relies on information usually provided by the user in the $_GET variable (query string).

The code for everything BUT orphan is the same.. all it does is call wp_edit_attachments_query() which hack the $_GET array into thinking that these values (posts_per_page) where provided.. In our case these values were unset so this is why you see 0..

The attached patch makes the “hack” work even for unattached elements..

BTW this whole pagination code is pretty ugly.. Maybe a re-write would be require to avoid such bugs in the future..

Enjoy

[matdumsa]

Path for this Ticket.. This patch was made from rev:13795

[ocean90]

If you use upload.diff you get a wrong number for $wp_query->found_posts. Its the total number of posts and not of the attachments.

[wpmuguru]

(In [14185]) fix page count calc for unattached media, props PeteMall, see #12448