Using localhost without VHOST should be allowed for MS sites

[Denis-de-Bernardy]

I recall managing to have made WPMU work in such a setup, using IIS on a Windows box. I fail to see why an Apache Box running on a Mac can't do as much.

[Denis-de-Bernardy]

first pass: allow to install MS in localhost/~denis/wp-trunk/

[Denis-de-Bernardy]

Tested on MacOS X/Apache, I'm not running into any issues (beyond the bugs I'm reporting) while playing around with the network options.

Needs testing by a few more devs.

[nacin]

What's wrong with localhost.localdomain?

[westi]

This sounds like a reasonable idea.

It would be great to have an easy way to test on localhost for subdir multisite installs.

[nacin]

I agree. Unless I'm missing something, the only reason is for subdomain installs, in which case this looks good.

[nacin]

Apparently, the historical reason for blocking localhost lies with cookie domains. I briefly looked through the code and did not see this to be a problem at this point.

I have a refreshed patch already running locally, so I'll kick the tires a bit more on this.

[nacin]

Some notes:

First, ​http://trac.mu.wordpress.org/ticket/182, from 2006.

Second, I ran into some cookie problems converting a localhost.localdomain install to localhost. But a fresh install performed great. (I probably missed something I needed to change in the DB in the conversion attempt.)

I'm going to commit some improvements and also my patch. If we find it has problems, we can revert.

[nacin]

Actually, I forgot -- I did have to make a modification to the constant definitions to make it work.

[nacin]

(In [13622]) Allow localhost in a multisite subdirectory install. More network.php improvements. see #12457 for localhost. see #11816

[nacin]

I'm thinking we can abstract this out further and check for the lack of a period in the hostname, instead of == 'localhost'. Necessary?

[Denis-de-Bernardy]

Replying to nacin:

I'm thinking we can abstract this out further and check for the lack of a period in the hostname, instead of == 'localhost'. Necessary?

that would be slower. are there any benefits for doing so?

[nacin]

Replying to Denis-de-Bernardy:

Replying to nacin:
that would be slower. are there any benefits for doing so?

Slower? Marginally. The benefit is we would catch the rare local hostname that isn't localhost but also doesn't support subdomains.

[wpmuguru]

(In [13707]) fix warning on cookie_domain, see #12457

[nacin]

Re-open if any other bugs are found in testing.