Opened 15 years ago
Closed 15 years ago
#12468 closed defect (bug) (duplicate)
there is no delete/disable header option under appearance / header
Reported by: | Denis-de-Bernardy | Owned by: | colinloretz |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.0 |
Component: | Themes | Keywords: | has-patch |
Focuses: | Cc: |
Description
it's all in the title. especially useful when the file got deleted. or if no header is desired.
Attachments (4)
Change History (12)
#2
@
15 years ago
- Owner set to colinloretz
- Status changed from new to accepted
This one will require a bit of conversation.
I've included a screenshot and patch for adding a new option to the radio boxes for selecting "No Header Image".
The UI for removing custom backgrounds is a little different and uses a "Remove background" button. I opted for the new radio button instead because I felt it made the most sense.
Alteration to the twentyten theme will also be necessary to detect if get_header_image() is empty. I have attached a diff for this as well.
This offers flexibility for using a theme's registered headers, no header or an uploaded custom header.
#5
@
15 years ago
UI Feedback: Good concept, I think it works. It would be good to see "no header" as the first option rather than the last, let's make sure that radio button aligns with the image (centered vertically) in the same way as the others.
#6
@
15 years ago
@johnonolan: Thanks for the feedback. I've added it in it's own table row for now (instead of figuring out shifting the items over one) but I will look at adding it to the front of the options.
I've fixed the css for alignment.
in addition, when viewing appearance / header with an invalid (deleted) header, clicking the save header button further down to choose from one of the default ones, but without selecting one beforehand, apparently selects a random header.