Add AYS on unsaved menu changes

[Denis-de-Bernardy]

if you edit a menu, and change its contents, by adding/removing items and/or editing existing items. if you forget to click save all changes before leaving, it discards the changes. the save all changes should not be needed, much like we're doing in the widgets screen.

[ocean90]

Its not really a bug.

[jane]

I'd rather see an AYS. No autosave on menus. People will work on these and not want them updated without an explicit save/publish.

[markjaquith]

(In [14741]) Add AYS notice on unsaved menu changes. see #12472

[markjaquith]

Re-open if this needs more work.

Known issue that will not be fixed: if you make a change (like a sort, or an add, or a text modification) and then revert it, such that you are back at the original state, it will still think you've made a change. The change sensing is dumb... it triggers on the input/textarea/select changes, the "Add" events, the sort events, and the hierarchy change events.

Deletes happen asynchronously with their own AYS, so these don't count as a change.

[Denis-de-Bernardy]

Pardon for re-opening, but... why should widgets autosave whenever anything gets changed, while menu items should get an annoying AYS?

Mac pref screens autosave nearly all changed settings for good reasons.

[ryan]

We don't autosave because we don't want push interim menu changes live. This is a big complaint with widgets. As you make modifications, they go live.

This is by design for 3.0. We'll see what the feedback looks like once 3.0 is out and adjust course as needed.

[voyagerfan5761]

I was about to come and say the same thing as ryan. Something that's an integral part of the whole site layout like menus (and, yes, widgets) probably shouldn't auto-save. Ideally, users would have the ability to preview changes before they go live, but that could be a plugin.