WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12485 closed defect (bug) (fixed)

Maintenance Message is not flagged for translation

Reported by: hakre Owned by: nacin
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: I18N Keywords: needs-patch
Focuses: Cc:

Description

Hardcoded message in english text:

	<head>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
		<title>Maintenance</title>

	</head>
	<body>
		<h1>Briefly unavailable for scheduled maintenance. Check back in a minute.</h1>
	</body>

file: wp-inlcludes/load.php

Change History (7)

comment:1 hakre4 years ago

And does a die(). wp_die() should be prefered to make it testable.

comment:2 nacin4 years ago

See also #12357.

We don't have wp_die() included yet at this point.

comment:3 hakre4 years ago

For reference: /*WP_I18N_MARKER*/ [string] /*/WP_I18N_MARKER*/

for die(); good point, so a casual check could be made for making testable:

if (!function_exists('wp_die')) die(); else wp_die();

References: #12444, #11892

And/Or since it is a pluggable, wp_die() could be inited far front and becomming more functional later. Might help in #12444 as well.

comment:4 hakre4 years ago

for the translation list: function dead_db() in wp-includes/functions.php has another hardencoded text to offer.

comment:5 nacin4 years ago

  • Owner set to nacin
  • Status changed from new to reviewing

comment:6 nacin4 years ago

  • Component changed from General to i18n

comment:7 nacin4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

(In [13822]) WP_I18N_* for .maintenance strings. fixes #12485

Note: See TracTickets for help on using tickets.