WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12499 closed enhancement (wontfix)

Plugin Installer could leave a warning, if it falls back from direct install to FTP install

Reported by: keatch Owned by: westi
Milestone: Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: dev-feedback
Focuses: Cc:

Description

Currently using svn version 13573.
When I try to install a plugin via the web interface under Plugins -> Add New, the installation puts me to the credential for the FTP upload?

Are there some new variables that enable / disable this behavior?

Additional information:
Platform Linux
MySQL v5.0
The user is Admin
Language: english

vesion.php
$wp_db_version = 13309;

Change History (10)

comment:1 keatch4 years ago

  • Cc keatch added

comment:2 keatch4 years ago

  • Component changed from General to Plugins
  • Owner set to westi

comment:3 TobiasBg4 years ago

  • Keywords one-click plugins removed
  • Resolution set to invalid
  • Status changed from new to closed

This means that your server is not configured properly. Most likely, this is due to non-sufficient permissions for file creation/modification/writing (for the PHP user).

If that happens, the plugin installer falls back to the FTP method.

Please ask in the Support Forums for further assistance with the server configuration.

Feel free to re-open this ticket, if there really is a bug or you find out more.

comment:5 keatch4 years ago

Ok, thanks.
Was a permission mismatch.

Looking if it's possible to leave a warning message, for the user, so it can know why this feature is not working!

Thanks to all for the support!

comment:6 TobiasBg4 years ago

  • Keywords dev-feedback added
  • Milestone changed from 3.0 to 3.1
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Summary changed from One-click install via Web fails for Plugin / Themes. Always goes to FTP Install to Plugin Installer could leave a warning, if it falls back from direct install to FTP install
  • Type changed from defect (bug) to enhancement
  • Version 3.0 deleted

That makes it an enhancement.
I'm therefore re-opening it, to hear what others are saying.
I also changed the title to be closer to your idea.
And I moved it to 3.1, as it qualifies for feature freeze affected, right?

comment:7 keatch4 years ago

Yes, thanks. That's right!

Can you point me to the files that is managing the check?
( maybe I think is class-wp-ugrader.php in wp-admin/includes folder )

comment:8 dd324 years ago

  • Component changed from Plugins to Upgrade/Install

Can you point me to the files that is managing the check?

get_filesystem_method() in wp-admin/includes/file.php

IMO, falling back to FTP doesnt deserve a warning, Using the FTP method is much more common than one would hope for.

For 99% of users, the automatically chosen method is the only one that can work on their server configuration, most people cant "fix" (remove) the ftp check without changing the server configuration. You had a server-misconfiguration which lead WordPress to fallback to a method it knew would work (as it could see, that doing it the direct way (writing files directly to the hard drive) was going to result in the files being owned by a different user, Therefor, switching to FTP forces the files to be created by the ftp owner, leading to less user problems down the line.

comment:9 TobiasBg4 years ago

Thanks for the background info, Dion.

I agree that a warning is pretty much useless, as the average user probably has never heard about file permissions or chmod.

Wontfix then?

comment:10 dd324 years ago

  • Milestone 3.1 deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed

I agree, I'm going to close this as wontfix.

I do think that some extra documentation could do in the wild, but i dont think this is a place to discuss that, people posting their experiences on their blogs will help those later down the line through google searches :)

Note: See TracTickets for help on using tickets.