WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#12517 closed task (blessed) (fixed)

Move Tools -> Upgrade to Dashboard -> Updates

Reported by: dd32 Owned by: dd32
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Upgrade/Install Keywords: ui-feedback
Focuses: Cc:

Change History (28)

#1 @dd32
9 years ago

(In [13588]) Move Tools -> Upgrade to Dashboard -> Updates. As per dev meetup today. See #12517

#2 @mdawaffe
9 years ago

Clicking the "Dashboard" menu item now takes me to update-core.php.

#3 @jane
9 years ago

We probably need to make an Overview item for the actual dashboard screen.

#4 @wpmuguru
9 years ago

(In [13590]) UI upgrade -> update, see #12517

#5 @hakre
9 years ago

After commit, filename contains still the old wording: ms-upgrade-network.php

#6 follow-up: @dd32
9 years ago

Clicking the "Dashboard" menu item now takes me to update-core.php.

Whoops.. All fixed now.

Should probably add a Bubble there counting sum(core, theme, pugin) updates.

#7 @dd32
9 years ago

Whoops.. All fixed now.

Err.. Ryan fixed that in [13589], Not sure why i didnt see the commit.. Eitherway, That reduces the conditionals called anyway.

#8 @dd32
9 years ago

(In [13593]) Add an update count bubble to the Updates menu. See #12517

#9 in reply to: ↑ 6 @caesarsgrunt
9 years ago

Replying to dd32:

Clicking the "Dashboard" menu item now takes me to update-core.php.

Whoops.. All fixed now.

It still does this in r13597...

#10 @dd32
9 years ago

It still does this in r13597...

What configuration are you running under? Multisite? Administrator? Other Account?

Should've been fixed by ryan in [13589]

#11 @dd32
9 years ago

  • Type changed from defect (bug) to task (blessed)

#12 @dd32
9 years ago

(In [13603]) Do not count Development versions of WordPress as having a core-update available. See #12517

#13 @dd32
9 years ago

(In [13607]) GUU: Add Update breakdown to Title attribute of update bubble. See #12517

#14 @caesarsgrunt
9 years ago

Standard installation (not multisite - actually I haven't worked out how to install it as multisite yet). Administrator account (using name caesar, not admin). No other accounts set up.

#15 @dd32
9 years ago

Standard installation (not multisite - actually I haven't worked out how to install it as multisite yet). Administrator account (using name caesar, not admin). No other accounts set up.

Got the same setup here, I cant fault it.

Your wp-admin/menu.php file isnt out of date is it?

#16 @caesarsgrunt
9 years ago

Not sure what that file is, but I'll have a look and I'll install from scratch, and report back.

#17 @caesarsgrunt
9 years ago

Working fine now after reinstalling. Sorry for the false alarm...

#18 @hakre
9 years ago

Are URLs (that stuff that can be typed into your browser's address bar) considered part of the UI or not? If those are considered part, the file should reflect the new wording so that it can be requested as intended.

#19 @voyagerfan5761
9 years ago

  • Cc WordPress@… added

#20 @dd32
9 years ago

Are URLs (that stuff that can be typed into your browser's address bar) considered part of the UI or not?

They generally would be, however - Since this is a pre-existing file, and we already have a 'update.php' and 'upgrade.php', I think its best to leave this as-is.

Can anyone see anything that needs to be implemented here before this ticket is closed? Bugs can go into new tickets.

#21 @nacin
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#22 @nacin
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Actually..

We currently list updates for inactive plugins and themes. Those are included in the bubble. In testing themes and downloads, I've downloaded quite a few on a testbed, and now I'm getting a bubble of '5' even though I'm using Twenty Ten and have no plans to use those in the future.

I'm not so concerned about the bubble, but we do say "You are running version %s", which isn't exactly accurate for an inactive plugin or theme. The string should indicate "installed," and more so, it'd be nice for inactive vs. active to be indicated.

Aside from all that, I'm noticing the bubble is blue on hover, orange normally, and gray when you're on the Dashboard menu. Was the idea to eliminate the orange? It just seems kind of inconsistent.

#23 @dd32
9 years ago

Just because a theme or plugin is inactive, i dont see why they shouldn't recieve update notifications. Plugin-wise, some people may decide to disable a plugin until its updated, an update may include a fix for a problem they're having. For themes, I agree that most will never use the theme even though its installed, but take Multisite, or any other scenario where multiple installs use the same theme repo (Custom content dir's, custom wp-config.php's etc)... just because it isnt used on the current site, doesnt mean its not used elsewhere..

The bubble mimicks the comment bubble, and the plugin update bubble, all use the same colours. If anything, the Blue should go.. (and be replaced with the grey)

#24 @jane
9 years ago

@dd32: agreed. Use case for themes, though:
-user loves their theme.
-user sees new WP feature and wants to use it, but theme doesn't support it, so they deactivate and use a different theme, waiting for the original theme author to do an update to support the new WP feature.

I'd like to see updates on everything showing up, even if it's deactivated.

#25 @nacin
9 years ago

  • Keywords ui-feedback added

I'm agree with including inactive plugins and themes. I was actually just setting myself up for the string and the bubble color. So:

  • Orange/blue/gray -- pick two. (Orange is leftover from 2.6. Is our goal to eliminate it?)
  • "You are running" to something that's accurate. I'd kind of like to see an indicator of what is active versus inactive when looking through bulk upgrades. Or, we change the string for both active and inactive to something "You have version %s installed."

#26 @johnonolan
9 years ago

  • Cc johnonolan added

As far as I remember from the last UI meetings Jane is looking to get rid of the orange, however I think we do need a bright color there to indicate the call the action when active - I don't think blue is strong enough. Gray works for if it's inactive.

I think "You have version %s installed." works fine

#28 @nacin
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [14496]) Use a more generic string for GUU plugins and themes, as inactive items aren't 'running.' fixes #12517.

Note: See TracTickets for help on using tickets.