WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 4 years ago

#12518 new defect (bug)

XML-RPC newMediaObject should try to work out mime-type if not supplied

Reported by: jonquark Owned by: josephscott
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: XML-RPC Keywords: has-patch
Focuses: Cc:

Description

At least one XML-RPC client (MaStory on Maemo) does not set the type parameter on uploaded objects. This means we don't create appropriate thumbnails correctly.

Given some clients are on fairly low-power, simple devices, it's probably worth Wordpress attempting to determine the mime-type, especially as functions calls we /already/ make on attachments will give us that information already for the common-case of image uploads.

Attachments (2)

mimetype.patch (630 bytes) - added by jonquark 4 years ago.
If not supplied, determine mime-type for uploaded images
mimetype2.patch (866 bytes) - added by jonquark 4 years ago.
Alternative patch..now works with non-image mimetypes

Download all attachments as: .zip

Change History (6)

jonquark4 years ago

If not supplied, determine mime-type for uploaded images

comment:1 jonquark4 years ago

  • Component changed from General to XML-RPC
  • Milestone changed from Unassigned to Future Release
  • Owner set to josephscott

comment:2 josephscott4 years ago

  • Cc joseph@… added

I'd suggest running this through get_allowed_mime_types() before assuming that the upload is an image.

jonquark4 years ago

Alternative patch..now works with non-image mimetypes

comment:3 jonquark4 years ago

Hi Joseph,

When I came to address your comment, I realised that there is a wp_check_filetype() that works with a broader range of mime types.

I've attached a version of the patch that uses it (and also stops passing type to wp_upload_bits as that is deprecated in favour of a call to wp_check_filetype()).

Does that seem reasonable?

comment:4 jonquark4 years ago

  • Cc jonquark added
Note: See TracTickets for help on using tickets.