WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#12528 closed task (blessed) (fixed)

Support Themes in Unified Updater

Reported by: ryan Owned by: dd32
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

Theme update support was partially added to the Unified Updater (wp-admin/update-core.php) but never finished. Let's finish it.

Change History (12)

comment:1 follow-up: @jane5 years ago

We'll need to put a warning above the GUU themes section reminding people that updating a theme could overwrite any changes they've made, etc.

comment:2 @jane5 years ago

  • Type changed from defect (bug) to task (blessed)

comment:3 in reply to: ↑ 1 ; follow-up: @Denis-de-Bernardy5 years ago

Replying to jane:

We'll need to put a warning above the GUU themes section reminding people that updating a theme could overwrite any changes they've made, etc.

It would be sweet to allow theme authors to remove that using a filter. Some themes are built in such a way that you don't need to edit the templates in order to customize them...

comment:4 in reply to: ↑ 3 ; follow-up: @jane5 years ago

Replying to Denis-de-Bernardy:

It would be sweet to allow theme authors to remove that using a filter. Some themes are built in such a way that you don't need to edit the templates in order to customize them...

True, but some people will edit those themes anyway. not everything is covered in a theme options screen.

comment:5 in reply to: ↑ 4 @Denis-de-Bernardy5 years ago

Replying to jane:

Replying to Denis-de-Bernardy:

It would be sweet to allow theme authors to remove that using a filter. Some themes are built in such a way that you don't need to edit the templates in order to customize them...

True, but some people will edit those themes anyway. not everything is covered in a theme options screen.

It's not about options, it's about widgets. When your template (as in, the loop) is widget-based, there is absolutely no reason to edit the slightest file.

comment:6 @nacin5 years ago

It's not about options, it's about widgets. When your template (as in, the loop) is widget-based, there is absolutely no reason to edit the slightest file.

That doesn't mean they won't.

comment:7 @dd325 years ago

We'll need to put a warning above the GUU themes section reminding people that updating a theme could overwrite any changes they've made, etc.

That should probably be displayed in the Plugin & Theme editors too, linking to a codex article about child themes for the latter.

comment:8 @dd325 years ago

(In [13604]) First pass at completing the Themes component of the GUU. See #12528

comment:9 @dd325 years ago

(In [13686]) Bulk Theme Upgrades. See #12528 See #11232 for Bulk UI

comment:10 @dd325 years ago

(In [13687]) Force Theme update check on GUU. See #12528

comment:11 @voyagerfan57615 years ago

  • Cc WordPress@… added

comment:12 @dd325 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing as fixed.

Please report any bugs as a new ticket, unless it is better suited to either of these tickets:

#12517 - Moving Tools -> Upgrade to Dashboard -> Updates

#11232 - Bulk upgrade skin

Note: See TracTickets for help on using tickets.