Improve get_blog_count(), get_user_count() and get_sitestats()

[ocean90]

We can use *_site_transients().

More information in get_blog_count() and get_user_count()
(I use/need this information for #12460)

I also remove get_sitestats() because we have the two other functions.

[scribu]

Unless get_sitestats() was introduced in WP 3.0, you should move it to deprecated.php instead of removing it completely.

[ocean90]

add get_sitestats() to ms-deprecated.php

[ryan]

We can't change the return type of get_user_count() or get_blog_count(), and get_sitestats() must still be functional. Those are all used in MU and back compat must be maintained. All of those would have to be deprecated and replaced with new functions. Also, see count_users().

[ocean90]

Ok, I declare get_blog_count(), get_user_count(), get_sitestats() as deprecated functions and create ms_count_blogs() and ms_count_users() (like wp_count_comments).

[ocean90]

alternative: leave get_sitestats() undeprecated

[dd32]

Also: No need to pass hard-coded queries through prepare() before querying them, That should only be done if placeholders are used within the query (ie. %d and %s); - Not sure why the original function is doing that.

[ocean90]

remove unneeded prepare()

[ryan]

Doing that may counts will kill performance on sites with lots of blogs and users. Is this for showing counts for the status filters on the ms-sites and users pages? I suggest leaving the counts off. Counting will make those pages unusably slow.

[nacin]

(In [13664]) get_blog_count() returns a number, not an object. Also, i18n fixes -- add plural string, and translator context. see #12531 for get_blog_count() discussion. see #12409 for ms-sites cleanup.

[ocean90]

ryan: Yep, it should be for that.

I reduce the queries to one and create 1,100 sites and make some tests and the counting doesn't make the site really 'unusably slow'. The results are also saved in the site transient.
So, I upload the new patch.

[wpmuguru]

If it were me, I would put the counting of site/user statuses in a plugin and use hooks to update the counts.

[ryan]

Try it with 10 million users and 10 million blogs.

I'd rather push this to 3.1.

[ocean90]

Ok, but we should improve the existing function for 3.0. See patch.

[nacin]

Moving back to 3.0 so we can update this to use the transients API.

We'll want to keep the timeout though.

[ocean90]

12531.6.patch is a new version with *_site_transients().

Replying to nacin:

We'll want to keep the timeout though.

I don't think that we need the timeout anymore, because we shouldn't need a new count, if nothing is changed.

[ryan]

These should be computed via cron jobs and stored in an option. The recalculation cost is too high to store it in a transient that might get pushed out of cache.

[nacin]

#15170