WP should cache menus

[Denis-de-Bernardy]

There's a prime example of how to do this in the menu ticket (i.e. the plugin I attached in #11817).

Shouldn't we be doing this in WP as well?

It basically goes:

• if it's a page, then try a post meta
• if it's search/404 request, then try a transient
• if it's anything else, then try a transient

The plugin also handles conditional flushing of the cache based on whether or not the permalink and/or the label changed.

[ptahdunbar]

Fixed in r13704

[nacin]

[13726]

[scribu]

I'm not so sure this should go into core, the same way that widget caching isn't in core.

The only thing that's cached is RSS feeds, since we don't want to flood other sites.

Installing a plugin like WP Super Cache solves the caching problem for the entire page.

[prettyboymp]

Replying to scribu:

I'm not so sure this should go into core, the same way that widget caching isn't in core.

The only thing that's cached is RSS feeds, since we don't want to flood other sites.

Installing a plugin like WP Super Cache solves the caching problem for the entire page.

I think this needs to be revisited, even if it's just creating a way to allow a plugin to cache the wp_get_nav_menu_items() function. A simple menu that is only one level deep causes 3 extra queries.

Almost all core widgets have caching or use functions that have caching built in and WP Super Cache isn't a solution for sites that have a high percentage of logged in users.

[peterwilsoncc]

Core appears to have changed around this code since the last substantive update. Doesn't appear to remain valid.