WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 2 years ago

#12539 new enhancement

Add hook to create_initial_post_types()

Reported by: mikeschinkel Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Posts, Post Types Keywords:
Focuses: Cc:

Description

I'd like to propose that create_initial_post_types() in wp-includes/post.php have a filter called 'initial_post_types' (or something else) that will allow a hook to remove default post types and/or modify the attributes of post types before they are registered. I've included a patch to illustrate. The same could be done with the post statues but doing so is a bit more complicated so I didn't implement that in case the core devs hate the idea.

As suggested by dd32 from #9674 I created this new ticket.

Attachments (1)

post.php.diff (4.9 KB) - added by mikeschinkel 4 years ago.
Update to /wp-includes/post.php to add a filter called 'initial_post_types'

Download all attachments as: .zip

Change History (11)

mikeschinkel4 years ago

Update to /wp-includes/post.php to add a filter called 'initial_post_types'

comment:1 mikeschinkel4 years ago

  • Cc mikeschinkel@… added

comment:2 unsalkorkmaz4 years ago

  • Cc unsalkorkmaz added

comment:3 nacin4 years ago

  • Milestone changed from Unassigned to 3.0

comment:4 mikeschinkel4 years ago

Thank you! :)

comment:5 nacin4 years ago

Not blessing it per se, but 3.0 would be the time to review this.

comment:6 follow-up: dd324 years ago

  • Milestone changed from 3.0 to 3.1

We're in feature freeze, Approaching Beta in the near future, This is an enhancement and is not a regression over the previous release. Moving to 3.1 for now.

The addition of the custom post_types to 3.0 has been of benefit, but mearly filtering these post_types is not all that needs to be done to prevent certain post types from being invisible to WordPress.

This would be better fixed in 3.1 as the post_type api and internal use matures.

comment:7 in reply to: ↑ 6 mikeschinkel4 years ago

Replying to dd32:

We're in feature freeze, Approaching Beta in the near future, This is an enhancement and is not a regression over the previous release. Moving to 3.1 for now.

The addition of the custom post_types to 3.0 has been of benefit, but mearly filtering these post_types is not all that needs to be done to prevent certain post types from being invisible to WordPress.

This would be better fixed in 3.1 as the post_type api and internal use matures.

Agreed. Better to do this one well vs. quickly.

comment:8 kevinB4 years ago

  • Cc kevinB added

comment:9 follow-up: nacin3 years ago

  • Milestone changed from Awaiting Triage to Future Release

I think we still have a long ways to go decoupling the core taxonomies and core post types...

comment:10 in reply to: ↑ 9 mikeschinkel2 years ago

I was just reviewing my tickets, and this was (partially) addressed in prior version but this ticket was never updated.

HOWEVER, and this does need to be addressed, create_initial_post_types() is called TWICE. See #19692.

Note: See TracTickets for help on using tickets.