Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#12553 closed defect (bug) (fixed)

Quick edit for link categories fails

Reported by: kpdesign's profile kpdesign Owned by: dd32's profile dd32
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

I am logged in as an admin, and try to use Quick Edit to make a change to a link category.

I make the desired changes, then click Update Category. The update fails and I'm given a Cheatin’ uh? message (see attached screenshot).

I can edit the link categories in regular edit mode.

This happens in both single and multi-site 3.0 installs.

Attachments (2)

wp3.0-link-cat-quick-edit-fail.png (6.8 KB) - added by kpdesign 16 years ago.
12553.diff (614 bytes) - added by mdawaffe 16 years ago.

Download all attachments as: .zip

Change History (7)

@mdawaffe
16 years ago

#1 @mdawaffe
16 years ago

  • Keywords has-patch commit added

I'm not sure why Link Categories has it's own admin page instead of using edit-tags.php?taxonomy=link_category, but the attached is a quick fix for the bug.

For taxonomies that use edit-tags.php?taxonomy=blah, there is already several hidden inputs with name="taxonomy", which is what the AJAX needs in order to function.

edit-link-categories.php has no such hidden input. Attached adds one to inline_edit_term_row().

#2 @nacin
16 years ago

  • Keywords quick-edit link-category removed
  • Owner set to dd32
  • Status changed from new to assigned

#3 @dd32
16 years ago

I'm not sure why Link Categories has it's own admin page instead of using edit-tags.php?taxonomy=link_category, but the attached is a quick fix for the bug.

Thats probably due to the poor handling of the Posts(Links) column, At present, the title of the column (and the link) are limited to Posts & edit.php.

Throwing the quickfix in first, should extend the table to handle the different column types & lables.

#4 @dd32
16 years ago

(In [13624]) Fix inline taxonomy Quick Edit. Props mdawaffe. See #12553

#5 @dd32
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

See #12285 for remaining issues

Note: See TracTickets for help on using tickets.