occasional blog option corruption for serialized values

[RogerTheriault]

get_blog_option sometimes / randomly returns nothing and corrupts/wipes out the entry for a serialized value. Seen as far back as WPMU 2.8, so this has been around. Traced it down to the call to unserialize - changed it to maybe_unserialize and the issue went away.

A patch for trunk is attached. Has only been tested on one installation.

[Denis-de-Bernardy]

patch is invalid. this is generally due to charset problems. WP is not multibyte safe, and neither are the underlying php functions.

punting this to future, since it'll probably never get solved before we get php6

[OpenHaus]

Check for an array and skip stripslash part

[OpenHaus]

I am also not able to retrieve an array saved as an option.

Warning: stripslashes() expects parameter 1 to be string, array given in /wordpress-3.0.1/wp-includes/ms-blogs.php on line 340

This is clearly a bug which needs to be handled. See get_blog_option_unserialize_patch.2.diff for a possible solution.

[mastermind]

The very simple solution would be to *not* use

if (! @unserialize( $value ) )
	$value = stripslashes( $value );

but

if (is_scalar( $value ) )
	$value = stripslashes( $value );

[mastermind]

One-liner, see comment 4

[ryan]

(In [16808]) Remove stripslashes(). No longer needed. Props RogerTheriault. fixes #12560