WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#12574 closed task (blessed) (fixed)

Update Tinymce

Reported by: pascal.herbert Owned by: azaozz
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: TinyMCE Keywords: dev-feedback
Focuses: Cc:

Description

Tinymce 3.3 was released today

Attachments (1)

tinymce-3.3.9.1.zip (230.1 KB) - added by Viper007Bond 4 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 miqrogroove4 years ago

#11158 is still broken? Meh...

comment:2 scribu4 years ago

  • Milestone changed from Unassigned to 3.0
  • Owner set to azaozz
  • Status changed from new to assigned
  • Type changed from defect (bug) to enhancement

comment:3 dd324 years ago

  • Keywords needs-patch added
  • Version set to 3.0

Is there anyone who's willing to take on merging TinyMCE? Or is this going to wait for the next release.

Azaozz is currently taking some time off due to illness, so I dont think he'll be working on it much..

comment:4 jane4 years ago

  • Keywords early added
  • Milestone changed from 3.0 to 3.1

I think this should wait for the next release. We're late going into beta, and shouldn't risk something like this breaking without Andrew on hand for immediate fixes. If someone wants to start working on it, it could go into 3.1 early.

comment:5 azaozz4 years ago

Agree with Jane. TinyMCE 3.3 came out a bit too late for inclusion in WordPress 3.0. It has some major changes and would require fixes to our custom plugins.

comment:6 nacin4 years ago

  • Milestone changed from Awaiting Triage to 3.1

comment:7 nacin4 years ago

  • Type changed from enhancement to task (blessed)

comment:8 nacin4 years ago

  • Component changed from Editor to TinyMCE

comment:9 Viper007Bond4 years ago

I had to ZIP the patch file as it was too big. Also included is wp-tinymce.js.gz.

This is a patch that applies TinyMCE v3.3.9.1 (3.3.9.2 was just released, so the patch will need refreshing).

Applying the patch seems to fix TinyMCE for IE9 (it's broken for IE9 in WP trunk), but the alignment buttons throw a Javascript error in all browsers. I have no idea why they aren't working. TinyMCE and Javascript aren't my strongest areas.

I'd appreciate it if someone else could take over for me. :)

Viper007Bond4 years ago

comment:10 azaozz4 years ago

Added TinyMCE 3.3.9.2, first run. Needs testing in all current browsers, mainly our custom plugins. See [15683].

comment:11 azaozz4 years ago

(In [15684]) Properly align all buttons in the TinyMCE dialogs, see #12574

comment:12 mrmist4 years ago

There are some usability issues with this on IE8 (non-compatibility-mode). This manifests when you have typed more than one boxes worth of text and the scroll bar comes into force. After that point, the scroll bar jumps back to the top of the text box on every further "enter" press or if you highlight some text and then move the mouse outside of the text area.

This problem is not new, it's previously existed as #10438 and #14749 but I was hoping that the tinymce update would fix it.

Switching to full screen seems ok, but that isn't an option in the HTML view.

comment:13 lloydbudd4 years ago

  • Keywords needs-patch early removed

FYI this (TinyMCE 3.3.9.2) has been deployed to wp.com

comment:14 follow-up: jane3 years ago

  • Keywords dev-feedback added

@azaozz: Shall we close this ticket for now since it's been a month and let someone re-open or start a new ticket if they hit any snags later on?

comment:15 in reply to: ↑ 14 azaozz3 years ago

Replying to jane:
There are couple more changes in 3.3 that I'm still testing/working on. The most important is the new formats option that allows using CSS classes instead of inline styles or redefining the HTML elements that are used in the editor. I'll have a patch by 30th.

comment:16 azaozz3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [16090]) Editor: utilize the new "formats" option in TinyMCE, fix errors in IE when pressing Enter inside a caption box, fix resizing of the caption box when the user soft-resizes the image in the editor, fixes #12574

Note: See TracTickets for help on using tickets.