WordPress.org
Get WordPress

Make WordPress Core

Opened 17 years ago

Closed 16 years ago

Last modified 16 years ago

#12594 closed defect (bug) (fixed)

Use paths in include calls

Reported by: nacin Owned by: sorich87
Priority: normal Milestone: 3.0
Component: Performance Version:
Severity: normal Keywords:
Cc: Focuses:

Description

We often do require('admin.php') where require('./admin.php') would be quicker, as it would avoid the include_path directive.

We should audit core for instances where we include a file (it'd generally be a bootstrap) without specifying a relative or absolute path.

Attachments (1)

path_patch.diff​ (45.2 KB ) - added by sorich87 16 years ago.

Download all attachments as: .zip

Change History (10)

@sorich87
16 years ago

#1 @sorich87
16 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to sorich87
  • Status new → accepted

I added a relative path where no path is specified

#2 @nacin
16 years ago

  • Resolution → fixed
  • Status accepted → closed

(In [14139]) Use relative paths when including files, avoiding include_path. fixes #12594, props sorich87.

#3 @Viper007Bond
16 years ago

  • Resolution fixed
  • Status closed → reopened

Testing patches is a good idea. This completely breaks trunk.

Warning: require_once(./class-oembed.php) [function.require-once]: failed to open stream: No such file or directory in [...]\wp-includes\media.php  on line 1358

Fatal error: require_once() [function.require]: Failed opening required './class-oembed.php' (include_path='.;C:\php5\pear') in [...]\wp-includes\media.php on line 1358

#4 @Viper007Bond
16 years ago

That's from my localhost. Also breaks on my live block and scribu's localhost.

#5 @scribu
16 years ago

  • Keywords needs-patch added; has-patch removed
  • Priority normal → highest omg bbq
  • Severity normal → blocker

#6 @dd32
16 years ago

(In [14151]) Fix invalid paths in requires. See r14139. See #12594

#7 @dd32
16 years ago

Relative paths are taken from the calling script, not the current file.

So in those cases, it was trying to load ABSPATH/class-json.php

#8 @sorich87
16 years ago

  • Resolution → fixed
  • Status reopened → closed

Thanks dd32

#9 @nacin
16 years ago

  • Keywords needs-patch removed
  • Priority highest omg bbq → normal
  • Severity blocker → normal

My bad, sorry guys, I didn't have any embeds on my testbed. Completely missed that.

Note: See TracTickets for help on using tickets.