WordPress.org
Get WordPress

Make WordPress Core

Opened 20 years ago

Closed 20 years ago

#1260 closed defect (bug) (fixed)

r2552 switched pluggable-functions.php to DOS encoding

Reported by: anonymousbugger's profile anonymousbugger Owned by: matt's profile matt
Milestone: Priority: normal
Severity: minor Version: 1.5.1
Component: General Keywords:
Focuses: Cc:

Description

r2552 switched all linefeeds in pluggable-functions.php to \r\n, but the file should have native linefeeds.

Attachments (1)

bug1260_pluggable-functions.php​ (24.9 KB) - added by anonymousbugger 20 years ago.

Download all attachments as: .zip

Change History (7)

#1 @anonymousbugger
20 years ago

  • Patch set to No

#2 @coffee2code
20 years ago

Patch attached: bug1260_pluggable-functions.php

#4 @coffee2code
20 years ago

  • Patch changed from No to Yes
  • Resolution changed from 10 to 20
  • Status changed from new to closed

#5 @anonymousbugger
20 years ago

  • Resolution changed from 20 to 30
  • Status changed from closed to assigned

This bug is not fixed. 2552 changed the linefeeds from unix style to dos style.
Both is wrong, the file should have 'native' style (that means linefeeds will get converted from/to the client system's linefeed when checking out/commiting).

To fix this bug you have to:

  • Convert the linefeeds to what is 'native' on your platform
  • svn ps svn:eol-style native wp-includes/pluggable-functions.php
  • svn ci

#6 @matt
20 years ago

  • fixed_in_version set to 1.5.1
  • Owner changed from anonymous to matt
  • Resolution changed from 30 to 20
  • Status changed from assigned to closed

@anonymousbugger
20 years ago

Note: See TracTickets for help on using tickets.