Unable to add Endpoints to custom post_types

[dd32]

At present, Its impossible to add/apply Endpoints to custom post_type's due to the Endpoint Mask being applied to the rule creation.

Patch coming up has 2 sections to it

• Adds support to add_endpoint() to specify a Endpoint mask to apply to the rule, Defaults to EP_NONE as it currently does
  • Changes WP_Rewrite::extra_permastructs from a String to an Array of ($rule, EP_MASK)
    • Backwards compatibility is retained for anything which adds to that directly..

• Adds support to register_post_type() to specify a "permalink_epmask" arg, This defaults to EP_NONE as current
  • Can be set to, for example, EP_PERMALINK for the same endpoints as posts recieve
  • Used in conjuction with Part 1 of this patch, It allows for a custom value (For example, 2^{15) to be passed with the post AND passed with a Endpoint, The result is being able to register endpoints for a specific custom post_type.}

I suspect this also currently would render endpoints for taxonomies not possible, but that would be a much less often used process

[dd32]

That patch also includes a change to $ep_mask_specific being undefined. I'm not sure EP_NONE is the correct default for that flag given the location its being used: ​http://core.trac.wordpress.org/browser/trunk/wp-includes/rewrite.php#L1409

[dd32]

(In [13773]) Allow for a custom Endpoint Mask to be passed to add_endpoint(). Allows for endpoints to be targeted to specific rewrite rules. Allow custom post_types to specify their Endpoint mask. Allows for post_type's rewrite rules to inherit Post endpoints, or alternatively, allows for add_endpoint() to target specific post_types. Fixes #12605

[dd32]

Example use:

define('EP_WIKI', 131072); // 2^17. 2^13 is used by core.
register_post_type('wiki', array(
	'label' => __('Wiki'),
	'public' => true,
	'supports' => array('revisions', 'editor', 'title'),
	'permalink_epmask' => EP_WIKI,
	'hierarchical' => true
));
add_rewrite_endpoint('history', EP_WIKI);

The post_type 'wiki' rules will now include a /edit/(.../)? endpoint, which does not get applied to any other type of rule that core generates.

Care would need to be taken that any custom endpoints are in 2^{x format, and not currently in use by any other plugins loaded..}

[dd32]

The post_type 'wiki' rules will now include a /edit/(.../)? endpoint

Of course, i used the /history/(..../)? example in that code. Result is the same, just wrong name.

[ericlewis]

Replying to dd32:

Care would need to be taken that any custom endpoints are in 2^{x format, and not currently in use by any other plugins loaded..}

Indeed. This limits the wide-usage of plugins extending the endpoints API, as a developer would need to inspect code to ensure plugins that create custom endpoints are playing nicely with each other.