WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 4 years ago

#12636 closed enhancement (fixed)

Update sample output of a custom date via ajax

Reported by: nacin Owned by: garyc40
Milestone: 3.1 Priority: lowest
Severity: normal Version:
Component: UI Keywords:
Focuses: Cc:

Description

On Settings > General, we have instructions for users to "Click “Save Changes” to update sample output."

We should update the example via ajax when the input box that takes a PHP date string loses focus.

Attachments (1)

12636.diff (4.1 KB) - added by nacin 7 years ago.
Proof of concept.

Download all attachments as: .zip

Change History (9)

@nacin
7 years ago

Proof of concept.

#1 @nacin
7 years ago

  • Keywords has-patch needs-refresh added
  • Milestone changed from Awaiting Triage to 3.1
  • Priority changed from normal to lowest
  • Severity changed from normal to minor

Need to handle $_POST better in admin ajax.

#2 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15757]) Update via ajax the sample output of custom date/times on options-general. fixes #12636.

#3 @demetris
6 years ago

  • Cc dkikizas@… added
  • Resolution fixed deleted
  • Severity changed from minor to normal
  • Status changed from closed to reopened

I think we need to improve this. Now:

  1. The required action to have the sample output updated is not intuitive (and the UI offers not hint on what you need to do).
  2. More importantly, the workflow is not good.

Can’t we have the request sent after a small delay, so that you receive feedback while your cursor is still in the input box?

#4 @nacin
6 years ago

  • Keywords needs-patch added; has-patch needs-refresh removed

To be honest, I don't think the UI needs to hint. I think this is still a huge improvement over 3.0.

I don't have a problem with firing off the ajax request after a delay.

#5 @markjaquith
6 years ago

  • Milestone changed from 3.1 to Future Release

Let's iterate again in 3.2 dev cycle with the delay (only if changed, obviously). Done with it for 3.1.

#6 @markjaquith
6 years ago

  • Keywords 3.2-early added

#7 @garyc40
6 years ago

  • Owner set to garyc40
  • Status changed from reopened to assigned

Found another issue with this.

Try checking the radio box "Custom", enter a custom date / time format. Then click on another radio box (a preset format) instead of clicking randomly outside of the text input. The format inside of the text input is changed properly to that of the preset format, however, the ajax request is already sent and an invalid sample output appears.

#8 @helen
4 years ago

  • Keywords needs-patch 3.2-early removed
  • Milestone changed from Future Release to 3.1
  • Resolution set to fixed
  • Status changed from assigned to closed

This ticket has been sitting for quite a while and the spirit seems fixed in 3.1. Additional issues or enhancement are likely better off as new tickets at this point.

Note: See TracTickets for help on using tickets.