Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#12680 closed defect (bug) (wontfix)

Update description on old default theme (Kubrick)

Reported by: nacin Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Themes Keywords:
Focuses: Cc:


It's going to be confusing for (new) users to see Twenty Ten and WordPress Default side by side. We should rename WordPress Default to WordPress Kubrick, and change its description to reflect that it used to be the default theme (much like the Classic theme's description).

We can rename it in style.css and be done with it, or we can take more complicated approaches.

Things to consider:

  1. An active theme cannot be renamed without some problems. It used to be worse (see #12428), but the main issue now is that theme mods (header, background, etc.) are stored as mods_$theme, where $theme is the theme name (instead of the directory, for some reason).
  1. Do we rename the directory as well? If we do, we would need to avoid doing this if the theme is active (even as a parent). And we would need to account for "default" as always being an alias to "kubrick" when referencing the parent theme from a child theme as well.
  1. Renaming the directory in new installs makes sense, but how would we handle upgrades?
  1. How can we do this without breaking anything?

There are potentially more angles to this. See this IRC discussion among me, Viper007Bond, and jorbin.

This might be a good time to bring up the fact that the automatic upgrader copies over wp-content. Maybe it's time to rely on the theme/plugin upgraders to handle updating wp-content, and have instructions in there to copy over themes only if the theme directory is nonexistent? We won't be bundling any more plugins in core, and as we bundle new themes, they can be copied over (and then updated via the theme upgrader).

Attachments (1)

kubrick.diff (657 bytes) - added by jorbin 6 years ago.
Updates description to state that it is the former default theme

Download all attachments as: .zip

Change History (8)

#1 @jorbin
6 years ago

  • Cc aaron@… added

A solution that I just thought of would be to introduce the attribute of "Display Name" or something similar to the style sheet header that can allow us to have display a different name on the admin side, but still have it store the name in the database as whatever the "Theme Name" is. If Display name wasn't present, it could use theme name.

#2 @nacin
6 years ago

The point of the theme name now is for display. A new header is excessive.

We should never have used the theme name in the database in the first place. The proper fix would be to stop doing so.

Each time a theme is activated, if the new option name doesn't exist, we can check for the old option name (using the theme name) and move the options over. It should arguably be stored in one 'theme_mods' option anyway (not per theme).

#3 @josephscott
6 years ago

On the question of what would break, every child theme that lists the template as 'default'. I agree that it would be better to have used a real name for the theme instead of default.

#4 @nacin
6 years ago

  • Milestone 3.0 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

See #10654.

#5 @jorbin
6 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Summary changed from Rename old default theme to "Kubrick" to Update description on old default theme (Kubrick)

Understandable to not completely change things, however updating the description to accurately say that is the former default would make things a bit less confusing for new users.

6 years ago

Updates description to state that it is the former default theme

#6 @nacin
6 years ago

It's going to be pulled from core (see #10664). The description and name will be updated when it gets moved to the .org directory.

#7 @jorbin
6 years ago

  • Resolution set to wontfix
  • Status changed from reopened to closed

I assume you meant #10654

In that case I'm +1 on that instead.


Note: See TracTickets for help on using tickets.