WordPress.org

Make WordPress Core

Opened 8 years ago

Last modified 12 months ago

#12684 assigned feature request

Add Edit to Bulk Actions menu on Categories screen

Reported by: jane Owned by: dipalidhole27gmailcom
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Quick/Bulk Edit Keywords: good-first-bug has-patch
Focuses: ui Cc:

Description

On edit-tags.php?taxonomy=category the only bulk action is Delete, because we never got around to adding Edit. We should add Edit to the bulk actions menu so people can change category parents easily. Has been requested on the Ideas forum a number of times, so am starting a ticket. If there's a technical reason not to add Edit to the bulk actions on this screen, then we should get rid of the menu and just have a Delete button. Adding Edit would be preferable, though, for consistency and usefulness.

Attachments (5)

12684.patch (6.8 KB) - added by dipali.dhole27@… 3 years ago.
12684.1.patch (6.9 KB) - added by dipali.dhole27@… 3 years ago.
Added another patch with changes
12684_2.patch (14.0 KB) - added by dipali.dhole27@… 3 years ago.
Added the filter 'bulk_edit_custom_box'
12684_3.patch (15.5 KB) - added by dipali.dhole27@… 2 years ago.
Refreshed Patch
12684.4.patch (10.7 KB) - added by vinod dalvi 13 months ago.
Refreshed Patch

Download all attachments as: .zip

Change History (30)

#1 @meheranandk
8 years ago

How do you expect to do bulk edit? Have text boxes all lined up or something? Doesn't make a lot of sense.

#2 @jane
8 years ago

They would probably be columns with option to make children or parent or some such. The UI group will likely mock it up, but since this is targeted for 3.1, not 3.0, no one has started on it yet.

#3 @filosofo
8 years ago

  • Component changed from Taxonomy to UI
  • Owner filosofo deleted
  • Status changed from new to assigned

#4 @F J Kaiser
8 years ago

See Q#1 > ?? Would prefer to see bulk editing for users first. Ex.: http://core.trac.wordpress.org/ticket/11392

#5 @nacin
8 years ago

  • Milestone changed from Awaiting Triage to Future Release

#6 @nacin
8 years ago

  • Keywords ui-feedback added; category bulk edit removed

#7 @DrewAPicture
5 years ago

  • Component changed from UI to Quick/Bulk Edit
  • Keywords ui-focus added; ui-feedback removed

#8 @chriscct7
3 years ago

  • Keywords needs-patch good-first-bug added

I like the idea of this enhancement. Would make a good first bug for someone

#9 @nicholas_io
3 years ago

The proposed Bulk edit mode should allow edits only for setting terms parents?

Last edited 3 years ago by nicholas_io (previous) (diff)

#10 @penyaskito
3 years ago

I had a look at this during #wceu Contributor Day in Seville.

What I would expect from this feature is allowing the user to only edit the parent term. For that, we should add a inline-edit-parent.js providing the form for doing so. This can be based on inline-edit-tax.js.

I would add a inline_edit_parent method in WP_Terms_List_Table, returning the form for editing this.

WP_Terms_List_Table::get_bulk_actions should return a edit-parent action, which we need to handle at edit-tags.php.

Otherwise, we need a new page with a new form for doing that, which I don't think it is consistent with the rest of the interface.

Does this make sense?

#11 @nicholas_io
3 years ago

It makes sense @penyaskito. I'll try to make a patch for this, I'm already studying how this was done for the Posts.

About the 'edit-parent' action that get_bulk_actions should return, I think it's better to call simply 'edit', since we could add more edit options in the future.

#12 @dipali.dhole27@…
3 years ago

I worked on above feature request. Added patch for the same.

#13 @nicholas_io
3 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#14 @chriscct7
3 years ago

  • Keywords needs-refresh added; has-patch needs-testing removed

The REQUEST needs to be sanitized. Also "Parent Category" needs to be l10n'd

@dipali.dhole27@…
3 years ago

Added another patch with changes

#15 @dipali.dhole27@…
3 years ago

  • Keywords needs-testing added

#16 @Chouby
3 years ago

I would suggest to add the filter 'bulk_edit_custom_box' (the same way 'quick_edit_custom_box' exists for posts and taxonomies).

@dipali.dhole27@…
3 years ago

Added the filter 'bulk_edit_custom_box'

#17 @tzon
3 years ago

I tested it on Macbook Pro OS X. It worked great for 3 different levels of parents.

#18 @dipali.dhole27@…
3 years ago

  • Keywords has-patch added; needs-refresh removed

This ticket was mentioned in Slack in #core by dipali.dhole27. View the logs.


3 years ago

#20 @swissspidy
2 years ago

  • Keywords needs-refresh added

Just had a look at the patch. It doesn't apply cleanly anymore so definitely needs a refresh.

Some thoughts:

  • Do not change the .gitignore file.
  • WordPress coding standards need to be followed properly. For example, there's lots of empty lines and also undocumented hooks.
  • Use the --no-prefix flag when creating the patch using Git.

@dipali.dhole27@…
2 years ago

Refreshed Patch

#21 @dipali.dhole27@…
2 years ago

  • Keywords needs-testing needs-refresh removed

#22 @swissspidy
2 years ago

  • Keywords needs-refresh added

@dipali.dhole27@…: Thanks for updating the patch & updating the keywords! Trac doesn't send notifications for attachment uploads, so the refreshed patch went unnoticed.

Unfortunately, the latest patch does not apply cleanly anymore because of some changes in the JS file. Would you mind having another look? Don't forget to add a separate comment when you upload a new patch.

#23 @DrewAPicture
2 years ago

  • Owner set to dipalidhole27gmailcom

Assigning to mark the good-first-bug as "claimed".

@dipalidhole27gmailcom: See comment:22

@vinod dalvi
13 months ago

Refreshed Patch

#24 @vinod dalvi
13 months ago

  • Keywords needs-refresh removed

I have refreshed the patch.

This ticket was mentioned in Slack in #core by vinod-dalvi. View the logs.


12 months ago

Note: See TracTickets for help on using tickets.