Malformed permalinks for feeds and paged / generate_rewrite_rules
|Reported by:||t31os_||Owned by:||ryan|
|Component:||Rewrite Rules||Keywords:||has-patch commit|
All rewrite rules(custom or standard options, non-default obviously) seem to suffer for a minor issue on rewrite generation, on iterations 5 and 6, $query is empty for those iterations (Line 1337 - the for loop).. resulting in malformed rules, ie. index.php?&feed ..
$feedquery $feedquery2 $pagequery
Are effected as a result, 6 rules then contain the malformed query string..
Line 1349 sets this to an empty string.
$query = ( isset($queries) && is_array($queries) ) ? $queries[$num_toks - 1] : '';
Lines 1368, 1382, and 1386 then set rules incorrectly.
A simple fix, just conditionalise the three lines with a string comparison for those lines...
if( '' == $query ) // etc..
Or just use a ternary comparison to do the same..
Could not find an existing report for this, so please close if is indeed duplicate.
First trac submission, go easy on me.. ;)
Change History (18)
comment:15 @dd32 — 5 years ago
- Component changed from Permalinks to Rewrite Rules
- Milestone changed from 3.0 to 3.1