Author & Users shows all users on multisite

[ocean90]

On a multisite install go to a site backend and then to author&users, you should see all users of the network and not only the users of the current blog.

Also the delete function is broken, I think its because of the bug.

[ocean90]

You can test it as super admin or as admin of the current site.

[ryan]

For multisite, users deleted from users.php have their role removed from the current blog. We should only list users that have a role on the current blog if is_multisite().

[ryan]

Instead instead of being deleted, the *capabilities usermeta field for the user is being set to an empty string. WP_User_Search::prepare_query() fetches all users that have that field, whether it is empty or not.

[miqrogroove]

count_users() does the same, as it was based on WP_User_Search.

[ryan]

remove_user_from_blog() calls WP_User::remove_all_caps() which sets capabilities to an empty string. Maybe we should have it delete.

[andreasnrb]

Replying to ryan:

remove_user_from_blog() calls WP_User::remove_all_caps() which sets capabilities to an empty string. Maybe we should have it delete.

I have added a ticket for the hooks thing #12720.

[ocean90]

We should delete them, it fixes some other discrepancies on ms-sites.php. Patch added.

[nacin]

delete_user_meta() should only take two arguments. The third is for the current meta value, to distinguish between multiple metadata rows of the same key for an item.

[ocean90]

removed the third argument

[wpmuguru]

(In [13883]) delete user cap in remove_all_caps(), props ocean90, see #12711

[wpmuguru]

Before closing this ticket can we verify the last change didn't affect WP single site installs.

[TobiasBg]

Apparently it removes all users from being shown: #12767

[ocean90]

fix #12767

[ocean90]

​12711.4.patch should fix that. I tested it on single and ms installation, both works.

[scribu]

Confirming that 12711.4.patch fixes #12767.

[automattor]

(In [13894]) restore user list display in single site, props ocean90, see #12711, #12767

[wpmuguru]

Closing. If an issue is found, someone can reopen.