WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 4 weeks ago

#12722 new defect (bug)

Concurrent editing of widgets

Reported by: josephscott Owned by: azaozz
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Widgets Keywords: has-patch 3.7-early
Focuses: Cc:

Description

When two admin users edit widgets at the same time which ever one saves last wins. I think we'd need something like the post edit lock to be able warn users when someone else is already editing widgets.

Attachments (1)

12722.diff (6.5 KB) - added by wonderboymusic 2 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 @buch00905 years ago

  • Cc davebuchanan@… added

comment:2 @jane5 years ago

You had me at "the same time." Agreed.

comment:3 @scribu5 years ago

  • Milestone changed from Unassigned to 3.1

+1

comment:4 @nacin4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Triage to 3.1

comment:5 @ryan4 years ago

  • Milestone changed from 3.1 to Future Release

comment:6 @nacin4 years ago

  • Keywords 3.2-early added

@wonderboymusic2 years ago

comment:7 @wonderboymusic2 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 3.6

the gift of 3.2-early keeps on giving, and I think this is a great fit for the editing / locking / autosave vibes of this release.

I attached a first run at this. I had to write some JS to make the lock messages stay in tune with the sortable / draggable widget block things, but this overall widget-locking concept wasn't wildly complicated to implement

Feedbacks?

comment:8 @nacin2 years ago

  • Keywords 3.7-early added; 3.2-early removed
  • Milestone changed from 3.6 to Future Release

This is cool. Obviously too late for 3.6 now, but would be great for 3.7. Needs to be re-coded to leverage the heartbeat and probably an abstraction of some of the new locking code.

comment:9 @wonderboymusic21 months ago

  • Milestone changed from Future Release to 3.7

these are all marked 3.7-early

comment:10 @wonderboymusic19 months ago

  • Milestone changed from 3.7 to Future Release

No one has touched this since my initial patch

comment:11 @westonruter4 weeks ago

I'm starting to look at this in relation to concurrent editing in the Customizer: #31436

Note: See TracTickets for help on using tickets.