Fix [6326] - wp_unique_term_slug() when changing the parent

[nacin]

[6326] uses $args (as an array) when it appears it should use $term (an object).

It's never worked, so I'm hesitant to patch it as I imagine it might break something elsewhere in the taxonomy API.

Assigning to ryan for now, who authored the commit.

[westi]

dd32 and I were discussing this the other day.

I think there might already be a ticket for it.

let me search.

[nacin]

Yeah, dd32 and I discussed this as well, and he mentioned he had discussed it with you. I couldn't find another ticket and so I said I would create one.

[stephenh1988]

If fixed, it will simply return the slug if it is already the slug for the term. Would that not be expected behavior?

[nacin]

#24216 was marked as a duplicate.

[wonderboymusic]

Things like this really scare me

[wonderboymusic]

.2.diff is from develop root - all existing unit tests pass

[ryan]

With unit tests that demonstrate the behavior change

[ryan]

That unit tests passes with the patch and fails without. This code is not really exercised since wp_insert_post() and wp_update_post() never call wp_unique_term_slug() in this situation. You pretty much have to call wp_unique_term_slug() directly (like the unit tests do) to trigger this.

[wonderboymusic]

In 25106:

Check term_id against the $term object, not the non-existent var $args. Props rboren. Fixes #12729.