WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12733 closed enhancement (fixed)

Merge Twenty Ten print style into style.css

Reported by: demetris Owned by: iammattthomas
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

The attached patch merges 2010’s print.css into the main CSS file.

It does this to save an extra HTTP request.

This is considered good practice for speedy websites by speed maniacs (like your humble servant) and also by authoritative sources like: http://developer.yahoo.com/performance/rules.html

Putting the print rules into the main CSS is less compatible, but to a negligible degree: As far as I know, there is some problem with IE for Mac. The major usual suspect, IE for Windows, supports this technique since version 5.

NOTE:

I noticed that, in long web pages in Firefox, Twenty Ten only prints part of the document. This is independent of the merge and will have to be looked at separately.

Attachments (1)

t12733-twentyten-print-style-merge.patch (4.5 KB) - added by demetris 4 years ago.
Merge Twenty Ten print style into style.css

Download all attachments as: .zip

Change History (5)

demetris4 years ago

Merge Twenty Ten print style into style.css

comment:1 nacin4 years ago

  • Owner set to iammattthomas
  • Status changed from new to assigned

+1. Was looking at this the other day and never got around to ticketing it.

comment:2 iammattthomas4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [13872]) Merge twentyten print style into style.css. Fixes #12733. Props demetris.

comment:3 jamescollins4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

trunk/wp-content/themes/twentyten/print.css should probably be deleted from SVN, rather than just being emptied.

comment:4 iammattthomas4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Thanks, nice catch. fixed in r13873.

Note: See TracTickets for help on using tickets.